Remove legacy py.path argument support in hooks

Deprecated feature scheduled for removal in pytest 9. Part of #13893.

Author: bluetech

doc/en/deprecations.rst

@@ -297,33 +297,6 @@ Changed ``hookwrapper`` attributes:
 * ``historic``
 
 
-.. _legacy-path-hooks-deprecated:
-
-``py.path.local`` arguments for hooks replaced with ``pathlib.Path``
-~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-
-.. deprecated:: 7.0
-
-In order to support the transition from ``py.path.local`` to :mod:`pathlib`, the following hooks now receive additional arguments:
-
-*  :hook:`pytest_ignore_collect(collection_path: pathlib.Path) <pytest_ignore_collect>` as equivalent to ``path``
-*  :hook:`pytest_collect_file(file_path: pathlib.Path) <pytest_collect_file>` as equivalent to ``path``
-*  :hook:`pytest_pycollect_makemodule(module_path: pathlib.Path) <pytest_pycollect_makemodule>` as equivalent to ``path``
-*  :hook:`pytest_report_header(start_path: pathlib.Path) <pytest_report_header>` as equivalent to ``startdir``
-*  :hook:`pytest_report_collectionfinish(start_path: pathlib.Path) <pytest_report_collectionfinish>` as equivalent to ``startdir``
-
-The accompanying ``py.path.local`` based paths have been deprecated: plugins which manually invoke those hooks should only pass the new ``pathlib.Path`` arguments, and users should change their hook implementations to use the new ``pathlib.Path`` arguments.
-
-.. note::
-    The name of the :class:`~_pytest.nodes.Node` arguments and attributes,
-    :ref:`outlined above <node-ctor-fspath-deprecation>` (the new attribute
-    being ``path``) is **the opposite** of the situation for hooks (the old
-    argument being ``path``).
-
-    This is an unfortunate artifact due to historical reasons, which should be
-    resolved in future versions as we slowly get rid of the :pypi:`py`
-    dependency (see :issue:`9283` for a longer discussion).
-
 Directly constructing internal classes
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 
@@ -430,6 +403,34 @@ an appropriate period of deprecation has passed.
 
 Some breaking changes which could not be deprecated are also listed.
 
+.. _legacy-path-hooks-deprecated:
+
+``py.path.local`` arguments for hooks replaced with ``pathlib.Path``
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+.. deprecated:: 7.0
+.. versionremoved:: 9.0
+
+In order to support the transition from ``py.path.local`` to :mod:`pathlib`, the following hooks now receive additional arguments:
+
+*  :hook:`pytest_ignore_collect(collection_path: pathlib.Path) <pytest_ignore_collect>` as equivalent to ``path``
+*  :hook:`pytest_collect_file(file_path: pathlib.Path) <pytest_collect_file>` as equivalent to ``path``
+*  :hook:`pytest_pycollect_makemodule(module_path: pathlib.Path) <pytest_pycollect_makemodule>` as equivalent to ``path``
+*  :hook:`pytest_report_header(start_path: pathlib.Path) <pytest_report_header>` as equivalent to ``startdir``
+*  :hook:`pytest_report_collectionfinish(start_path: pathlib.Path) <pytest_report_collectionfinish>` as equivalent to ``startdir``
+
+The accompanying ``py.path.local`` based paths have been deprecated: plugins which manually invoke those hooks should only pass the new ``pathlib.Path`` arguments, and users should change their hook implementations to use the new ``pathlib.Path`` arguments.
+
+.. note::
+    The name of the :class:`~_pytest.nodes.Node` arguments and attributes,
+    :ref:`outlined above <node-ctor-fspath-deprecation>` (the new attribute
+    being ``path``) is **the opposite** of the situation for hooks (the old
+    argument being ``path``).
+
+    This is an unfortunate artifact due to historical reasons, which should be
+    resolved in future versions as we slowly get rid of the :pypi:`py`
+    dependency (see :issue:`9283` for a longer discussion).
+
 .. _yield tests deprecated:
 
 ``yield`` tests

src/_pytest/config/__init__.py

@@ -38,14 +38,12 @@
 from typing import TYPE_CHECKING
 import warnings
 
-import pluggy
 from pluggy import HookimplMarker
 from pluggy import HookimplOpts
 from pluggy import HookspecMarker
 from pluggy import HookspecOpts
 from pluggy import PluginManager
 
-from .compat import PathAwareHookProxy
 from .exceptions import PrintHelp as PrintHelp
 from .exceptions import UsageError as UsageError
 from .findpaths import determine_setup
@@ -1087,7 +1085,7 @@ def __init__(
         self._store = self.stash
 
         self.trace = self.pluginmanager.trace.root.get("config")
-        self.hook: pluggy.HookRelay = PathAwareHookProxy(self.pluginmanager.hook)  # type: ignore[assignment]
+        self.hook = self.pluginmanager.hook
         self._inicache: dict[str, Any] = {}
         self._cleanup_stack = contextlib.ExitStack()
         self.pluginmanager.register(self, "pytestconfig")

src/_pytest/config/compat.py

@@ -1,26 +1,8 @@
 from __future__ import annotations
 
-from collections.abc import Mapping
-import functools
 from pathlib import Path
-from typing import Any
-import warnings
-
-import pluggy
 
 from ..compat import LEGACY_PATH
-from ..compat import legacy_path
-from ..deprecated import HOOK_LEGACY_PATH_ARG
-
-
-# hookname: (Path, LEGACY_PATH)
-imply_paths_hooks: Mapping[str, tuple[str, str]] = {
-    "pytest_ignore_collect": ("collection_path", "path"),
-    "pytest_collect_file": ("file_path", "path"),
-    "pytest_pycollect_makemodule": ("module_path", "path"),
-    "pytest_report_header": ("start_path", "startdir"),
-    "pytest_report_collectionfinish": ("start_path", "startdir"),
-}
 
 
 def _check_path(path: Path, fspath: LEGACY_PATH) -> None:
@@ -29,57 +11,3 @@ def _check_path(path: Path, fspath: LEGACY_PATH) -> None:
             f"Path({fspath!r}) != {path!r}\n"
             "if both path and fspath are given they need to be equal"
         )
-
-
-class PathAwareHookProxy:
-    """
-    this helper wraps around hook callers
-    until pluggy supports fixingcalls, this one will do
-
-    it currently doesn't return full hook caller proxies for fixed hooks,
-    this may have to be changed later depending on bugs
-    """
-
-    def __init__(self, hook_relay: pluggy.HookRelay) -> None:
-        self._hook_relay = hook_relay
-
-    def __dir__(self) -> list[str]:
-        return dir(self._hook_relay)
-
-    def __getattr__(self, key: str) -> pluggy.HookCaller:
-        hook: pluggy.HookCaller = getattr(self._hook_relay, key)
-        if key not in imply_paths_hooks:
-            self.__dict__[key] = hook
-            return hook
-        else:
-            path_var, fspath_var = imply_paths_hooks[key]
-
-            @functools.wraps(hook)
-            def fixed_hook(**kw: Any) -> Any:
-                path_value: Path | None = kw.pop(path_var, None)
-                fspath_value: LEGACY_PATH | None = kw.pop(fspath_var, None)
-                if fspath_value is not None:
-                    warnings.warn(
-                        HOOK_LEGACY_PATH_ARG.format(
-                            pylib_path_arg=fspath_var, pathlib_path_arg=path_var
-                        ),
-                        stacklevel=2,
-                    )
-                if path_value is not None:
-                    if fspath_value is not None:
-                        _check_path(path_value, fspath_value)
-                    else:
-                        fspath_value = legacy_path(path_value)
-                else:
-                    assert fspath_value is not None
-                    path_value = Path(fspath_value)
-
-                kw[path_var] = path_value
-                kw[fspath_var] = fspath_value
-                return hook(**kw)
-
-            fixed_hook.name = hook.name  # type: ignore[attr-defined]
-            fixed_hook.spec = hook.spec  # type: ignore[attr-defined]
-            fixed_hook.__name__ = key
-            self.__dict__[key] = fixed_hook
-            return fixed_hook  # type: ignore[return-value]

src/_pytest/deprecated.py

@@ -39,13 +39,6 @@
 PRIVATE = PytestDeprecationWarning("A private pytest class or function was used.")
 
 
-HOOK_LEGACY_PATH_ARG = UnformattedWarning(
-    PytestRemovedIn9Warning,
-    "The ({pylib_path_arg}: py.path.local) argument is deprecated, please use ({pathlib_path_arg}: pathlib.Path)\n"
-    "see https://docs.pytest.org/en/latest/deprecations.html"
-    "#py-path-local-arguments-for-hooks-replaced-with-pathlib-path",
-)
-
 NODE_CTOR_FSPATH_ARG = UnformattedWarning(
     PytestRemovedIn9Warning,
     "The (fspath: py.path.local) argument to {node_type_name} is deprecated. "

src/_pytest/hookspec.py

@@ -13,8 +13,6 @@
 
 from pluggy import HookspecMarker
 
-from .deprecated import HOOK_LEGACY_PATH_ARG
-
 
 if TYPE_CHECKING:
     import pdb
@@ -23,7 +21,6 @@
 
     from _pytest._code.code import ExceptionInfo
     from _pytest._code.code import ExceptionRepr
-    from _pytest.compat import LEGACY_PATH
     from _pytest.config import _PluggyPlugin
     from _pytest.config import Config
     from _pytest.config import ExitCode
@@ -302,17 +299,8 @@ def pytest_collection_finish(session: Session) -> None:
     """
 
 
-@hookspec(
-    firstresult=True,
-    warn_on_impl_args={
-        "path": HOOK_LEGACY_PATH_ARG.format(
-            pylib_path_arg="path", pathlib_path_arg="collection_path"
-        ),
-    },
-)
-def pytest_ignore_collect(
-    collection_path: Path, path: LEGACY_PATH, config: Config
-) -> bool | None:
+@hookspec(firstresult=True)
+def pytest_ignore_collect(collection_path: Path, config: Config) -> bool | None:
     """Return ``True`` to ignore this path for collection.
 
     Return ``None`` to let other plugins ignore the path for collection.
@@ -333,7 +321,7 @@ def pytest_ignore_collect(
     .. versionchanged:: 7.0.0
         The ``collection_path`` parameter was added as a :class:`pathlib.Path`
         equivalent of the ``path`` parameter. The ``path`` parameter
-        has been deprecated.
+        has been deprecated and removed in pytest 9.0.0.
 
     Use in conftest plugins
     =======================
@@ -375,16 +363,7 @@ def pytest_collect_directory(path: Path, parent: Collector) -> Collector | None:
     """
 
 
-@hookspec(
-    warn_on_impl_args={
-        "path": HOOK_LEGACY_PATH_ARG.format(
-            pylib_path_arg="path", pathlib_path_arg="file_path"
-        ),
-    },
-)
-def pytest_collect_file(
-    file_path: Path, path: LEGACY_PATH, parent: Collector
-) -> Collector | None:
+def pytest_collect_file(file_path: Path, parent: Collector) -> Collector | None:
     """Create a :class:`~pytest.Collector` for the given path, or None if not relevant.
 
     For best results, the returned collector should be a subclass of
@@ -399,7 +378,7 @@ def pytest_collect_file(
     .. versionchanged:: 7.0.0
         The ``file_path`` parameter was added as a :class:`pathlib.Path`
         equivalent of the ``path`` parameter. The ``path`` parameter
-        has been deprecated.
+        has been deprecated and removed in pytest 9.0.0.
 
     Use in conftest plugins
     =======================
@@ -501,17 +480,8 @@ def pytest_make_collect_report(collector: Collector) -> CollectReport | None:
 # -------------------------------------------------------------------------
 
 
-@hookspec(
-    firstresult=True,
-    warn_on_impl_args={
-        "path": HOOK_LEGACY_PATH_ARG.format(
-            pylib_path_arg="path", pathlib_path_arg="module_path"
-        ),
-    },
-)
-def pytest_pycollect_makemodule(
-    module_path: Path, path: LEGACY_PATH, parent
-) -> Module | None:
+@hookspec(firstresult=True)
+def pytest_pycollect_makemodule(module_path: Path, parent) -> Module | None:
     """Return a :class:`pytest.Module` collector or None for the given path.
 
     This hook will be called for each matching test module path.
@@ -526,9 +496,8 @@ def pytest_pycollect_makemodule(
 
     .. versionchanged:: 7.0.0
         The ``module_path`` parameter was added as a :class:`pathlib.Path`
-        equivalent of the ``path`` parameter.
-
-        The ``path`` parameter has been deprecated in favor of ``fspath``.
+        equivalent of the ``path`` parameter. The ``path`` parameter has been
+        deprecated in favor of ``module_path`` and removed in pytest 9.0.0.
 
     Use in conftest plugins
     =======================
@@ -1036,16 +1005,7 @@ def pytest_assertion_pass(item: Item, lineno: int, orig: str, expl: str) -> None
 # -------------------------------------------------------------------------
 
 
-@hookspec(
-    warn_on_impl_args={
-        "startdir": HOOK_LEGACY_PATH_ARG.format(
-            pylib_path_arg="startdir", pathlib_path_arg="start_path"
-        ),
-    },
-)
-def pytest_report_header(  # type:ignore[empty-body]
-    config: Config, start_path: Path, startdir: LEGACY_PATH
-) -> str | list[str]:
+def pytest_report_header(config: Config, start_path: Path) -> str | list[str]:  # type: ignore[empty-body]
     """Return a string or list of strings to be displayed as header info for terminal reporting.
 
     :param config: The pytest config object.
@@ -1063,7 +1023,7 @@ def pytest_report_header(  # type:ignore[empty-body]
     .. versionchanged:: 7.0.0
         The ``start_path`` parameter was added as a :class:`pathlib.Path`
         equivalent of the ``startdir`` parameter. The ``startdir`` parameter
-        has been deprecated.
+        has been deprecated and removed in pytest 9.0.0.
 
     Use in conftest plugins
     =======================
@@ -1072,17 +1032,9 @@ def pytest_report_header(  # type:ignore[empty-body]
     """
 
 
-@hookspec(
-    warn_on_impl_args={
-        "startdir": HOOK_LEGACY_PATH_ARG.format(
-            pylib_path_arg="startdir", pathlib_path_arg="start_path"
-        ),
-    },
-)
-def pytest_report_collectionfinish(  # type:ignore[empty-body]
+def pytest_report_collectionfinish(  # type: ignore[empty-body]
     config: Config,
     start_path: Path,
-    startdir: LEGACY_PATH,
     items: Sequence[Item],
 ) -> str | list[str]:
     """Return a string or list of strings to be displayed after collection
@@ -1108,7 +1060,7 @@ def pytest_report_collectionfinish(  # type:ignore[empty-body]
     .. versionchanged:: 7.0.0
         The ``start_path`` parameter was added as a :class:`pathlib.Path`
         equivalent of the ``startdir`` parameter. The ``startdir`` parameter
-        has been deprecated.
+        has been deprecated and removed in pytest 9.0.0.
 
     Use in conftest plugins
     =======================

src/_pytest/main.py

@@ -34,7 +34,6 @@
 from _pytest.config import UsageError
 from _pytest.config.argparsing import OverrideIniAction
 from _pytest.config.argparsing import Parser
-from _pytest.config.compat import PathAwareHookProxy
 from _pytest.outcomes import exit
 from _pytest.pathlib import absolutepath
 from _pytest.pathlib import bestrelpath
@@ -727,7 +726,7 @@ def gethookproxy(self, fspath: os.PathLike[str]) -> pluggy.HookRelay:
         proxy: pluggy.HookRelay
         if remove_mods:
             # One or more conftests are not in use at this path.
-            proxy = PathAwareHookProxy(FSHookProxy(pm, remove_mods))  # type: ignore[arg-type,assignment]
+            proxy = FSHookProxy(pm, remove_mods)  # type: ignore[assignment]
         else:
             # All plugins are active for this fspath.
             proxy = self.config.hook