[4.6] fixes for python4

Author: asottile

changelog/5801.trivial.rst

@@ -0,0 +1 @@
+Fixes python version checks (detected by ``flake8-2020``) in case python4 becomes a thing.

src/_pytest/pastebin.py

@@ -79,7 +79,7 @@ def create_new_paste(contents):
 
     params = {
         "code": contents,
-        "lexer": "python3" if sys.version_info[0] == 3 else "python",
+        "lexer": "python3" if sys.version_info[0] >= 3 else "python",
         "expiry": "1week",
     }
     url = "https://bpaste.net"

src/_pytest/pytester.py

@@ -1124,7 +1124,7 @@ def handle_timeout():
 
             if timeout is None:
                 ret = popen.wait()
-            elif six.PY3:
+            elif not six.PY2:
                 try:
                     ret = popen.wait(timeout)
                 except subprocess.TimeoutExpired:

testing/acceptance_test.py

@@ -223,7 +223,7 @@ def foo():
                 "conftest.py:2: in foo",
                 "    import qwerty",
                 "E   {}: No module named {q}qwerty{q}".format(
-                    exc_name, q="'" if six.PY3 else ""
+                    exc_name, q="" if six.PY2 else "'"
                 ),
             ]
         )

testing/python/raises.py

@@ -289,7 +289,7 @@ class TestUnicodeHandling:
 
     success = dummy_context_manager
     py2_only = pytest.mark.skipif(
-        six.PY3, reason="bytes in raises only supported in Python 2"
+        not six.PY2, reason="bytes in raises only supported in Python 2"
     )
 
     @pytest.mark.parametrize(

testing/test_monkeypatch.py

@@ -209,15 +209,15 @@ class TestEnvironWarnings(object):
 
     VAR_NAME = u"PYTEST_INTERNAL_MY_VAR"
 
-    @pytest.mark.skipif(six.PY3, reason="Python 2 only test")
+    @pytest.mark.skipif(not six.PY2, reason="Python 2 only test")
     def test_setenv_unicode_key(self, monkeypatch):
         with pytest.warns(
             pytest.PytestWarning,
             match="Environment variable name {!r} should be str".format(self.VAR_NAME),
         ):
             monkeypatch.setenv(self.VAR_NAME, "2")
 
-    @pytest.mark.skipif(six.PY3, reason="Python 2 only test")
+    @pytest.mark.skipif(not six.PY2, reason="Python 2 only test")
     def test_delenv_unicode_key(self, monkeypatch):
         with pytest.warns(
             pytest.PytestWarning,

testing/test_pastebin.py

@@ -74,7 +74,7 @@ def test():
         """
         )
         result = testdir.runpytest("--pastebin=all")
-        if sys.version_info[0] == 3:
+        if sys.version_info[0] >= 3:
             expected_msg = "*assert '☺' == 1*"
         else:
             expected_msg = "*assert '\\xe2\\x98\\xba' == 1*"
@@ -126,7 +126,7 @@ def test_create_new_paste(self, pastebin, mocked_urlopen):
         assert len(mocked_urlopen) == 1
         url, data = mocked_urlopen[0]
         assert type(data) is bytes
-        lexer = "python3" if sys.version_info[0] == 3 else "python"
+        lexer = "python3" if sys.version_info[0] >= 3 else "python"
         assert url == "https://bpaste.net"
         assert "lexer=%s" % lexer in data.decode()
         assert "code=full-paste-contents" in data.decode()

testing/test_warnings.py

@@ -569,7 +569,7 @@ def test_hidden_by_system(self, testdir, monkeypatch):
         assert WARNINGS_SUMMARY_HEADER not in result.stdout.str()
 
 
-@pytest.mark.skipif(six.PY3, reason="Python 2 only issue")
+@pytest.mark.skipif(not six.PY2, reason="Python 2 only issue")
 def test_infinite_loop_warning_against_unicode_usage_py2(testdir):
     """
     We need to be careful when raising the warning about unicode usage with "warnings.warn"