Skip to content

support IPython DummyMod as __main__ module for pytest fixtures #12965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

support IPython DummyMod as __main__ module for pytest fixtures #12965

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5b9c246
support IPython DummyMod as __main__ module for pytest fixtures
smacke Nov 15, 2024
9c9c592
add comment
smacke Nov 15, 2024
05fdd5d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/_pytest/fixtures.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1734,8 +1734,16 @@
if holderobj in self._holderobjseen:
return

module_types = (types.ModuleType,)
# support IPython's DummyMod if the module containing it has been imported
if (
DummyMod := getattr(
sys.modules.get("IPython.core.interactiveshell"), "DummyMod", None
)
) is not None:
module_types += (DummyMod,)

Check warning on line 1744 in src/_pytest/fixtures.py

View check run for this annotation

Codecov / codecov/patch

src/_pytest/fixtures.py#L1744 

Added line #L1744 was not covered by tests
# Avoid accessing `@property` (and other descriptors) when iterating fixtures.
if not safe_isclass(holderobj) and not isinstance(holderobj, types.ModuleType):
if not safe_isclass(holderobj) and not isinstance(holderobj, module_types):
holderobj_tp: object = type(holderobj)
else:
holderobj_tp = holderobj
Expand Down
Loading