From 18c0f75cb1e90647125bd47bece689cf5fb3eb4b Mon Sep 17 00:00:00 2001
From: Ran Benita <ran@unusedvar.com>
Date: Tue, 7 Oct 2025 22:34:15 +0300
Subject: [PATCH] testing: add a test demonstrating why `prune_dependency_tree`
 is needed

Currently the `prune_dependency_tree` method is not semantically
covered; if the call to it is commented out, all tests still pass.

Add a test that would fail, to prevent regressions and show why it's
(annoyingly) needed.
---
 testing/python/fixtures.py | 36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/testing/python/fixtures.py b/testing/python/fixtures.py
index d673eac7742..10941c3f9e3 100644
--- a/testing/python/fixtures.py
+++ b/testing/python/fixtures.py
@@ -5071,6 +5071,42 @@ def test_method(self, /, fix):
     result.assert_outcomes(passed=1)
 
 
+def test_parametrization_dependency_pruning(pytester: Pytester) -> None:
+    """Test that when a fixture is dynamically shadowed by parameterization, it
+    is properly pruned and not executed."""
+    pytester.makepyfile(
+        """
+        import pytest
+
+
+        # This fixture should never run because shadowed_fixture is parametrized.
+        @pytest.fixture
+        def boom():
+            raise RuntimeError("BOOM!")
+
+
+        # This fixture is shadowed by metafunc.parametrize in pytest_generate_tests.
+        @pytest.fixture
+        def shadowed_fixture(boom):
+            return "fixture_value"
+
+
+        # Dynamically parametrize shadowed_fixture, replacing the fixture with direct values.
+        def pytest_generate_tests(metafunc):
+            if "shadowed_fixture" in metafunc.fixturenames:
+                metafunc.parametrize("shadowed_fixture", ["param1", "param2"])
+
+
+        # This test should receive shadowed_fixture as a parametrized value, and
+        # boom should not explode.
+        def test_shadowed(shadowed_fixture):
+            assert shadowed_fixture in ["param1", "param2"]
+        """
+    )
+    result = pytester.runpytest()
+    result.assert_outcomes(passed=2)
+
+
 def test_fixture_closure_with_overrides(pytester: Pytester) -> None:
     """Test that an item's static fixture closure properly includes transitive
     dependencies through overridden fixtures (#13773)."""