correct-class-fixtures (#10819) (#14011) #14071
Open
+77
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yastcher
commented
Dec 28, 2025
yastcher
commented
- closes Inherit fixture from baseclass with class scope fails #14011
- closes Fixture with scope=class and autouse=True is not executed from mother's test class #10819
yastcher
force-pushed
the
fix/14011-10819-correct-class-fixtures
branch
3 times, most recently
from
6c5967f to
9772d0c
Compare
psf-chronographer
bot
added
the
bot:chronographer:provided
yastcher
force-pushed
the
fix/14011-10819-correct-class-fixtures
branch
from
9772d0c to
acd357c
Compare
yastcher
force-pushed
the
fix/14011-10819-correct-class-fixtures
branch
from
acd357c to
ff1759c
Compare
| pass | ||
|
|
||
| @pytest.fixture(scope="class") | ||
| def fix(self) -> typing.Generator[None]: |
Member
There was a problem hiding this comment.
reminds me that we need to ensure that class scope fixtures do not actually ever get a instance - class scope is above instances and should get a class
yastcher
force-pushed
the
fix/14011-10819-correct-class-fixtures
branch
from
ff1759c to
1a31c29
Compare
yastcher
force-pushed
the
fix/14011-10819-correct-class-fixtures
branch
from
1a31c29 to
02be4af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.