avoid signed conversion

jhunsaker · jhunsaker · commit 56a9e4d98ca7 · 2021-09-22T11:21:57.000-04:00
diff --git a/program/src/oracle/upd_aggregate.h b/program/src/oracle/upd_aggregate.h
@@ -15,9 +15,9 @@ extern "C" {
 
 static void pd_scale( pd_t *n )
 {
-  int neg = n->v_ < 0L;
-  uint64_t v = neg?-n->v_:n->v_;
-  for( ;v&0xfffffffff0000000UL; v/= 10UL, ++n->e_ );
+  int const neg = n->v_ < 0L;
+  int64_t v = neg ? -n->v_ : n->v_; // make v positive for loop condition
+  for( ; v >= ( 1L << 28 ); v /= 10L, ++n->e_ );
   n->v_ = neg ? -v : v;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -15,9 +15,9 @@ extern "C" {`
`15`	`15`
`16`	`16`	`static void pd_scale( pd_t *n )`
`17`	`17`	`{`
`18`		`- int neg = n->v_ < 0L;`
`19`		`- uint64_t v = neg?-n->v_:n->v_;`
`20`		`- for( ;v&0xfffffffff0000000UL; v/= 10UL, ++n->e_ );`
	`18`	`+ int const neg = n->v_ < 0L;`
	`19`	`+ int64_t v = neg ? -n->v_ : n->v_; // make v positive for loop condition`
	`20`	`+ for( ; v >= ( 1L << 28 ); v /= 10L, ++n->e_ );`
`21`	`21`	`n->v_ = neg ? -v : v;`
`22`	`22`	`}`
`23`	`23`