[twap] Delete old twap implementation (#358)

* checkpoint

* Remove all old sma files

* Bring back warnings denial

* restore PRICE_ACCOUNT_SIZE

* Restore PRICE_ACCOUNT_SIZE

* Add check for the upper bound

* Oops,fix test

* Typo

* Fix CI

Author: guibescos

program/c/src/oracle/oracle.h

@@ -7,13 +7,6 @@
 extern "C" {
 #endif
 
-// The size of the "time machine" account defined in the
-// Rust portion of the codebase.
-const uint64_t TIME_MACHINE_STRUCT_SIZE = 1200ULL;
-
-const uint64_t EXTRA_PUBLISHER_SPACE = 3072ULL;
-
-
 // magic number at head of account
 #define PC_MAGIC 0xa1b2c3d4
 
@@ -205,7 +198,10 @@ typedef struct pc_price
 
 static_assert( sizeof( pc_price_t ) == 3312, "" );
 
-const uint64_t PRICE_ACCOUNT_SIZE = TIME_MACHINE_STRUCT_SIZE + EXTRA_PUBLISHER_SPACE + sizeof( pc_price_t );
+// This constant needs to be an upper bound of the price account size, it is used within pythd for ztsd.
+// It is set tighly to the current price account + 96 component prices + 48 bytes for cumulative sums
+const uint64_t PRICE_ACCOUNT_SIZE = 3312 + 96 * sizeof( pc_price_comp_t) + 48;
+
 
 // command enumeration
 typedef enum {

program/rust/src/lib.rs

@@ -8,7 +8,6 @@ mod deserialize;
 mod error;
 mod instruction;
 mod processor;
-mod time_machine_types;
 mod utils;
 
 #[cfg(test)]

program/rust/src/processor/upd_price.rs

@@ -126,23 +126,6 @@ pub fn upd_price(
         }
     }
 
-    #[cfg(test)]
-    // Sma feature disabled in production for now
-    {
-        use crate::accounts::PythAccount;
-        let account_len = price_account.try_data_len()?;
-        if aggregate_updated
-            && account_len == crate::time_machine_types::PriceAccountWrapper::MINIMUM_SIZE
-        {
-            let mut price_account = load_checked::<crate::time_machine_types::PriceAccountWrapper>(
-                price_account,
-                cmd_args.header.version,
-            )?;
-            price_account.add_price_to_time_machine()?;
-        }
-    }
-
-
     // Try to update the publisher's price
     if is_component_update(cmd_args)? {
         let status: u32 =

program/rust/src/tests/mod.rs

@@ -16,12 +16,9 @@ mod test_publish;
 mod test_publish_batch;
 mod test_set_min_pub;
 mod test_sizes;
-mod test_sma;
-mod test_sma_epoch_transition;
 mod test_upd_aggregate;
 mod test_upd_permissions;
 mod test_upd_price;
 mod test_upd_price_no_fail_on_error;
 mod test_upd_product;
-mod test_upd_sma;
 mod test_utils;

program/rust/src/tests/test_sizes.rs

@@ -31,7 +31,6 @@ use {
             UpdPriceArgs,
         },
         tests::test_utils::AccountSetup,
-        time_machine_types::PriceAccountWrapper,
         utils::try_convert,
     },
     solana_program::pubkey::Pubkey,
@@ -74,10 +73,8 @@ fn test_sizes() {
     assert_eq!(size_of::<PriceComponent>(), 96);
     assert_eq!(size_of::<PriceEma>(), 24);
     assert_eq!(size_of::<PriceAccount>(), 3312);
-    assert_eq!(
-        size_of::<PriceAccountWrapper>(),
-        try_convert::<_, usize>(PRICE_ACCOUNT_SIZE).unwrap()
-    );
+    assert_eq!(PRICE_ACCOUNT_SIZE, 12576);
+    assert!(size_of::<PriceAccount>() <= try_convert::<_, usize>(PRICE_ACCOUNT_SIZE).unwrap());
     assert_eq!(size_of::<PermissionAccount>(), 112);
 }