fix mem error/leak

Author: richardbrooks2000

pc/pub_stats.cpp

@@ -64,7 +64,7 @@ void pub_stats::get_quartiles( const uint32_t *hist, uint32_t q[4] ) const
   unsigned j=0;
   for( uint64_t i=0; i != num_buckets && j != 4; ++i ) {
     cum += hist[i];
-    while ( cum >= pct[j]*num_recv_ && j != 4) {
+    while ( j != 4 && cum >= pct[j]*num_recv_ ) {
       q[j++] = i;
     }
   }

pc/request.cpp

@@ -1361,6 +1361,14 @@ product::product( const pub_key& acc )
   sreq_->set_sub( this );
 }
 
+product::~product()
+{
+  for( price *ptr: pvec_ ) {
+    delete ptr;
+  }
+  pvec_.clear();
+}
+
 pub_key *product::get_account()
 {
   return &acc_;

pc/request.hpp

@@ -496,6 +496,7 @@ namespace pc
   public:
 
     product( const pub_key& );
+    virtual ~product();
     void reset();
     void submit() override;
     void on_response( rpc::get_account_info * ) override;

pctest/test_publish.cpp

@@ -11,7 +11,6 @@ class test_connect : public pc::manager_sub
 {
 public:
   test_connect();
-  virtual ~test_connect();
 
   // on connection to (but not initialization) solana validator
   void on_connect( pc::manager * ) override;
@@ -31,6 +30,8 @@ class test_connect : public pc::manager_sub
   // get price from map
   pc::price *get_price( const std::string& ) const;
 
+  void teardown();
+
 private:
   test_publish *pub1_;     // SYMBOL1 publisher
   test_publish *pub2_;     // SYMBOL2 publisher
@@ -94,10 +95,11 @@ test_connect::test_connect()
 {
 }
 
-test_connect::~test_connect()
+void test_connect::teardown()
 {
   delete pub1_;
   delete pub2_;
+  pub1_ = pub2_ = nullptr;
 }
 
 void test_connect::on_connect( pc::manager * )
@@ -388,6 +390,8 @@ int main(int argc, char** argv)
     std::cerr << "test_publish: " << mgr.get_err_msg() << std::endl;
     retcode = 1;
   }
+  sub.teardown();
+
   return retcode;
 }