fix: add remapping to abi gen

Author: tejasbadadare

target_chains/ethereum/abi_generator/src/index.js

@@ -25,6 +25,10 @@ function generateAbi(contracts) {
     sources,
     settings: {
       outputSelection,
+      remappings: [
+        // Needed for @pythnetwork/pulse-sdk-solidity since it depends on @pythnetwork/pyth-sdk-solidity
+        "@pythnetwork/=./node_modules/@pythnetwork/",
+      ],
     },
   };
 
@@ -42,9 +46,28 @@ function generateAbi(contracts) {
     fs.mkdirSync("abis");
   }
 
+  // Report compilation failures
+  if (output.errors) {
+    // We can still generate ABIs with warnings, only throw for errors
+    const errors = output.errors.filter((e) => e.severity === "error");
+    if (errors.length > 0) {
+      console.error("Compilation errors:");
+      for (const error of errors) {
+        console.error(error.formattedMessage || error.message);
+      }
+      throw new Error("Compilation failed due to errors");
+    }
+  }
+
   for (let contract of contracts) {
     const contractFile = `${contract}.sol`;
 
+    if (!output.contracts[contractFile]) {
+      throw new Error(`Unable to produce ABI for ${contractFile}.`);
+    }
+    if (!output.contracts[contractFile][contract]) {
+      throw new Error(`Unable to produce ABI for ${contractFile}:${contract}.`);
+    }
     const abi = output.contracts[contractFile][contract].abi;
     fs.writeFileSync(
       `abis/${contract}.json`,

target_chains/ethereum/pulse_sdk/solidity/SchedulerErrors.sol

@@ -2,37 +2,39 @@
 
 pragma solidity ^0.8.0;
 
-// Authorization errors
-error Unauthorized();
+library SchedulerErrors {
+    // Authorization errors
+    error Unauthorized();
 
-// Subscription state errors
-error InactiveSubscription();
-error InsufficientBalance();
-error CannotUpdatePermanentSubscription();
+    // Subscription state errors
+    error InactiveSubscription();
+    error InsufficientBalance();
+    error CannotUpdatePermanentSubscription();
 
-// Price feed errors
-error InvalidPriceId(bytes32 providedPriceId, bytes32 expectedPriceId);
-error InvalidPriceIdsLength(uint256 providedLength, uint256 expectedLength);
-error EmptyPriceIds();
-error TooManyPriceIds(uint256 provided, uint256 maximum);
-error DuplicatePriceId(bytes32 priceId);
-error PriceSlotMismatch();
+    // Price feed errors
+    error InvalidPriceId(bytes32 providedPriceId, bytes32 expectedPriceId);
+    error InvalidPriceIdsLength(uint256 providedLength, uint256 expectedLength);
+    error EmptyPriceIds();
+    error TooManyPriceIds(uint256 provided, uint256 maximum);
+    error DuplicatePriceId(bytes32 priceId);
+    error PriceSlotMismatch();
 
-// Update criteria errors
-error InvalidUpdateCriteria();
-error UpdateConditionsNotMet();
-error TimestampTooOld(
-    uint256 providedUpdateTimestamp,
-    uint256 currentTimestamp
-);
-error TimestampOlderThanLastUpdate(
-    uint256 providedUpdateTimestamp,
-    uint256 lastUpdatedAt
-);
+    // Update criteria errors
+    error InvalidUpdateCriteria();
+    error UpdateConditionsNotMet();
+    error TimestampTooOld(
+        uint256 providedUpdateTimestamp,
+        uint256 currentTimestamp
+    );
+    error TimestampOlderThanLastUpdate(
+        uint256 providedUpdateTimestamp,
+        uint256 lastUpdatedAt
+    );
 
-// Whitelist errors
-error TooManyWhitelistedReaders(uint256 provided, uint256 maximum);
-error DuplicateWhitelistAddress(address addr);
+    // Whitelist errors
+    error TooManyWhitelistedReaders(uint256 provided, uint256 maximum);
+    error DuplicateWhitelistAddress(address addr);
 
-// Payment errors
-error KeeperPaymentFailed();
+    // Payment errors
+    error KeeperPaymentFailed();
+}