fix: update deposit limit check to only check incoming deposit amount

Co-Authored-By: Tejas Badadare <[email protected]>

Author: devin-ai-integration[bot]

target_chains/ethereum/contracts/contracts/pulse/Scheduler.sol

@@ -536,10 +536,7 @@ abstract contract Scheduler is IScheduler, SchedulerState {
         ];
 
         // Check deposit limit for permanent subscriptions
-        if (
-            params.isPermanent &&
-            status.balanceInWei + msg.value > MAX_DEPOSIT_LIMIT
-        ) {
+        if (params.isPermanent && msg.value > MAX_DEPOSIT_LIMIT) {
             revert MaxDepositLimitExceeded();
         }
 

target_chains/ethereum/contracts/forge-test/PulseScheduler.t.sol

@@ -818,14 +818,14 @@ contract SchedulerTest is Test, SchedulerEvents, PulseSchedulerTestUtils {
             "Balance should match deposit amount"
         );
 
-        // Test 3: Adding funds to a permanent subscription that would exceed MAX_DEPOSIT_LIMIT should fail
-        uint256 additionalFunds = 1 wei;
-        vm.deal(address(this), additionalFunds);
+        // Test 3: Adding funds to a permanent subscription with deposit exceeding MAX_DEPOSIT_LIMIT should fail
+        uint256 largeAdditionalFunds = maxDepositLimit + 1;
+        vm.deal(address(this), largeAdditionalFunds);
 
         vm.expectRevert(
             abi.encodeWithSelector(MaxDepositLimitExceeded.selector)
         );
-        scheduler.addFunds{value: additionalFunds}(subscriptionId);
+        scheduler.addFunds{value: largeAdditionalFunds}(subscriptionId);
 
         // Test 4: Adding funds to a permanent subscription within MAX_DEPOSIT_LIMIT should succeed
         // Create a non-permanent subscription to test partial funding