feat: remove app shell for now

alexcambose · alexcambose · commit 09c01dfff024 · 2025-10-07T17:41:26.000+01:00
diff --git a/apps/developer-hub/src/app/(docs)/[section]/layout.tsx b/apps/developer-hub/src/app/(docs)/[section]/layout.tsx
@@ -3,19 +3,7 @@ import type { ReactNode } from "react";
 
 import { docsOptions } from "../../../config/layout.config";
 
-export default async function Layout({
-  children,
-  ...props
-}: {
-  children: ReactNode;
-  params: Promise<{ section: string }>;
-}) {
-  const params = await props.params;
+export default function Layout({ children }: { children: ReactNode }) {
   const options = { ...docsOptions };
-  options.sidebar = {
-    ...options.sidebar,
-    // {} (empty object) means true
-    tabs: params.section === "price-feeds" ? {} : false,
-  };
   return <DocsLayout {...options}>{children}</DocsLayout>;
 }
diff --git a/apps/developer-hub/src/components/Root/global.css b/apps/developer-hub/src/components/Root/global.css
@@ -1,5 +1,5 @@
 @import "tailwindcss";
 @import "fumadocs-ui/css/neutral.css";
 @import "fumadocs-ui/css/preset.css";
-@import "./theme.css";
-@import "./fumadocs-global-style-overrides.css";
+@import "./theme.css"; /*this overrides the default colors to match the pyth branding */
+/* @import "./fumadocs-global-style-overrides.css"; */
diff --git a/apps/developer-hub/src/components/Root/index.tsx b/apps/developer-hub/src/components/Root/index.tsx
@@ -1,15 +1,8 @@
-import { AppBody, AppShellRoot } from "@pythnetwork/component-library/AppShell";
+import { RootProviders } from "@pythnetwork/component-library/AppShell";
 import { RootProvider as FumadocsRootProvider } from "fumadocs-ui/provider";
 import { NuqsAdapter } from "nuqs/adapters/next/app";
 import type { ReactNode } from "react";
 
-import {
-  AMPLITUDE_API_KEY,
-  ENABLE_ACCESSIBILITY_REPORTING,
-  GOOGLE_ANALYTICS_ID,
-} from "../../config/server";
-import { SearchButton } from "../search-button";
-
 import "./global.css";
 
 export const TABS = [
@@ -24,21 +17,19 @@ type Props = {
 };
 
 export const Root = ({ children }: Props) => (
-  <AppShellRoot
-    amplitudeApiKey={AMPLITUDE_API_KEY}
-    googleAnalyticsId={GOOGLE_ANALYTICS_ID}
-    enableAccessibilityReporting={ENABLE_ACCESSIBILITY_REPORTING}
-    providers={[NuqsAdapter]}
-  >
-    <FumadocsRootProvider
-      search={{
-        enabled: true,
-        options: {
-          api: "/api/search",
-        },
-      }}
-    >
-      <AppBody
+  <html lang="en">
+    <body>
+      <RootProviders providers={[NuqsAdapter]}>
+        <FumadocsRootProvider
+          search={{
+            enabled: true,
+            options: {
+              api: "/api/search",
+            },
+          }}
+        >
+          {/* commenting out the app body because we don't have the app shell anymore
+          <AppBody
         appName="Developer Hub"
         displaySupportButton={false}
         extraCta={<SearchButton />}
@@ -47,9 +38,11 @@ export const Root = ({ children }: Props) => (
           href: "https://dev-forum.pyth.network/",
         }}
         tabs={TABS}
-      >
-        {children}
-      </AppBody>
-    </FumadocsRootProvider>
-  </AppShellRoot>
+      > */}
+          {children}
+          {/* </AppBody> */}
+        </FumadocsRootProvider>
+      </RootProviders>
+    </body>
+  </html>
 );
diff --git a/apps/developer-hub/src/config/layout.config.tsx b/apps/developer-hub/src/config/layout.config.tsx
@@ -6,20 +6,36 @@ import { source } from "../lib/source";
 export const baseOptions: BaseLayoutProps = {
   nav: {
     enabled: true,
+    title: (
+      // todo change the logo here
+      <>
+        <svg
+          width="24"
+          height="24"
+          xmlns="http://www.w3.org/2000/svg"
+          aria-label="Logo"
+        >
+          <circle cx={12} cy={12} r={12} fill="currentColor" />
+        </svg>
+        Developer Hub
+      </>
+    ),
   },
-  themeSwitch: {
-    enabled: false, // Keep this false as the theme switch is handled by the component library
-  },
-  searchToggle: {
-    enabled: false,
-  },
+  // these are commented out because we don't have the app shell anymore
+  // themeSwitch: {
+  //   enabled: false, // Keep this false as the theme switch is handled by the component library
+  // },
+  // searchToggle: {
+  //   enabled: false,
+  // },
 };
 
 export const docsOptions: DocsLayoutProps = {
   ...baseOptions,
   tree: source.pageTree,
   sidebar: {
-    tabs: false,
-    collapsible: false,
+    // these are commented out because we don't have the app shell anymore
+    // tabs: false,
+    // collapsible: false,
   },
 };
