Skip to content

Commit 1d2fd07

Browse files
committed
conversion comments
1 parent 3010f6e commit 1d2fd07

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

apps/hermes/server/src/state/aggregate.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -370,8 +370,8 @@ where
370370
{
371371
let mut data = self.into().data.write().await;
372372
for ms in &message_states {
373-
let publish = ms.message.publish_time() as f64;
374-
let receive = ms.received_at as f64;
373+
let publish = ms.message.publish_time();
374+
let receive = ms.received_at;
375375
let latency = receive - publish;
376376
data.metrics.observe_publish_to_receive(latency);
377377
}

apps/hermes/server/src/state/aggregate/metrics.rs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,9 @@ impl Metrics {
8787
new
8888
}
8989

90-
pub fn observe_publish_to_receive(&mut self, latency_secs: f64) {
90+
pub fn observe_publish_to_receive(&mut self, latency_secs: i64) {
91+
// Histogram only accepts f64. The conversion is safe (never panics), but very large values lose precision.
92+
let latency_secs = latency_secs as f64;
9193
if latency_secs.is_finite() && latency_secs >= 0.0 {
9294
self.publish_to_receive_latency.observe(latency_secs);
9395
}

0 commit comments

Comments
 (0)