fix: remove unused clock variable in register function

- Remove unused clock variable that was causing CI build failure
- Keep clock variable in request_v2 function where it's actually used
- Fixes clippy warning and allows CI build to pass

Co-Authored-By: Jayant <[email protected]>

Author: devin-ai-integration[bot]

target_chains/solana/programs/pyth-entropy/src/error.rs

@@ -4,49 +4,49 @@ use anchor_lang::prelude::*;
 pub enum EntropyError {
     #[msg("Provider not found")]
     NoSuchProvider,
-    
+
     #[msg("Request not found")]
     NoSuchRequest,
-    
+
     #[msg("Insufficient fee provided")]
     InsufficientFee,
-    
+
     #[msg("Provider is out of randomness")]
     OutOfRandomness,
-    
+
     #[msg("Incorrect revelation provided")]
     IncorrectRevelation,
-    
+
     #[msg("Unauthorized access")]
     Unauthorized,
-    
+
     #[msg("Invalid reveal call")]
     InvalidRevealCall,
-    
+
     #[msg("Assertion failure")]
     AssertionFailure,
-    
+
     #[msg("Update too old")]
     UpdateTooOld,
-    
+
     #[msg("Last revealed too old")]
     LastRevealedTooOld,
-    
+
     #[msg("Insufficient gas")]
     InsufficientGas,
-    
+
     #[msg("Max gas limit exceeded")]
     MaxGasLimitExceeded,
-    
+
     #[msg("Blockhash unavailable")]
     BlockhashUnavailable,
-    
+
     #[msg("Zero minimum signatures")]
     ZeroMinimumSignatures,
-    
+
     #[msg("Invalid guardian order")]
     InvalidGuardianOrder,
-    
+
     #[msg("Invalid guardian index")]
     InvalidGuardianIndex,
 }

target_chains/solana/programs/pyth-entropy/src/lib.rs

@@ -36,7 +36,6 @@ pub mod pyth_entropy {
         require!(chain_length > 0, EntropyError::AssertionFailure);
 
         let provider_info = &mut ctx.accounts.provider_info;
-        let clock = Clock::get()?;
 
         provider_info.provider = ctx.accounts.provider.key();
         provider_info.fee_in_lamports = fee_in_lamports;
@@ -96,8 +95,10 @@ pub mod pyth_entropy {
 
         request_account.provider = provider_info.provider;
         request_account.sequence_number = assigned_sequence_number;
-        request_account.num_hashes = (assigned_sequence_number - provider_info.current_commitment_sequence_number) as u32;
-        request_account.commitment = combine_commitments(user_commitment, provider_info.current_commitment);
+        request_account.num_hashes =
+            (assigned_sequence_number - provider_info.current_commitment_sequence_number) as u32;
+        request_account.commitment =
+            combine_commitments(user_commitment, provider_info.current_commitment);
         request_account.requester = ctx.accounts.requester.key();
         request_account.block_number = clock.slot;
         request_account.use_blockhash = false;
@@ -231,8 +232,16 @@ pub mod pyth_entropy {
 
         provider_info.accrued_fees_in_lamports -= amount;
 
-        **ctx.accounts.provider.to_account_info().try_borrow_mut_lamports()? += amount;
-        **ctx.accounts.treasury.to_account_info().try_borrow_mut_lamports()? -= amount;
+        **ctx
+            .accounts
+            .provider
+            .to_account_info()
+            .try_borrow_mut_lamports()? += amount;
+        **ctx
+            .accounts
+            .treasury
+            .to_account_info()
+            .try_borrow_mut_lamports()? -= amount;
 
         emit!(Withdrawal {
             provider: provider_info.provider,
@@ -509,7 +518,8 @@ fn reveal_helper(
     user_contribution: [u8; 32],
     provider_contribution: [u8; 32],
 ) -> Result<[u8; 32]> {
-    let provider_commitment = construct_provider_commitment(request.num_hashes, provider_contribution);
+    let provider_commitment =
+        construct_provider_commitment(request.num_hashes, provider_contribution);
     let user_commitment = construct_user_commitment(user_contribution);
     let expected_commitment = combine_commitments(user_commitment, provider_commitment);
 
@@ -566,7 +576,11 @@ fn generate_user_contribution(clock: &Clock, requester: &Pubkey) -> [u8; 32] {
     keccak::hash(&data).to_bytes()
 }
 
-fn get_fee_v2_internal(provider_info: &ProviderInfo, config: &EntropyConfig, gas_limit: u32) -> u64 {
+fn get_fee_v2_internal(
+    provider_info: &ProviderInfo,
+    config: &EntropyConfig,
+    gas_limit: u32,
+) -> u64 {
     get_provider_fee_internal(provider_info, gas_limit) + config.pyth_fee_in_lamports
 }
 

target_chains/solana/programs/pyth-entropy/src/sdk.rs

@@ -1,5 +1,5 @@
 use {
-    crate::{CONFIG_SEED, PROVIDER_SEED, REQUEST_SEED, TREASURY_SEED, ID},
+    crate::{CONFIG_SEED, ID, PROVIDER_SEED, REQUEST_SEED, TREASURY_SEED},
     anchor_lang::{prelude::*, system_program, InstructionData},
     solana_program::instruction::Instruction,
 };
@@ -18,9 +18,14 @@ pub fn get_provider_info_address(provider: &Pubkey) -> Pubkey {
 
 pub fn get_request_address(provider: &Pubkey, sequence_number: u64) -> Pubkey {
     Pubkey::find_program_address(
-        &[REQUEST_SEED, provider.as_ref(), &sequence_number.to_le_bytes()],
+        &[
+            REQUEST_SEED,
+            provider.as_ref(),
+            &sequence_number.to_le_bytes(),
+        ],
         &ID,
-    ).0
+    )
+    .0
 }
 
 pub struct InitializeAccounts {
@@ -147,7 +152,8 @@ impl crate::instruction::Register {
                 commitment_metadata,
                 chain_length,
                 uri,
-            }.data(),
+            }
+            .data(),
         }
     }
 }
@@ -162,7 +168,8 @@ impl crate::instruction::RequestV2 {
     ) -> Instruction {
         Instruction {
             program_id: ID,
-            accounts: RequestV2Accounts::populate(payer, requester, provider, sequence_number).to_account_metas(None),
+            accounts: RequestV2Accounts::populate(payer, requester, provider, sequence_number)
+                .to_account_metas(None),
             data: crate::instruction::RequestV2 { gas_limit }.data(),
         }
     }