fix: better naming

Author: tejasbadadare

target_chains/ethereum/contracts/contracts/pulse/scheduler/IScheduler.sol

@@ -52,8 +52,8 @@ interface IScheduler is SchedulerEvents {
     function deactivateSubscription(uint256 subscriptionId) external;
 
     /**
-     * @notice Updates price feeds for a subscription
-     * @dev Verifies the updateData using the Pyth contract and validates that all feeds have the same timestamp
+     * @notice Updates price feeds for a subscription.
+     * Verifies the updateData using the Pyth contract and validates that all feeds have the same timestamp.
      * @param subscriptionId The ID of the subscription
      * @param updateData The price update data from Pyth
      * @param priceIds The IDs of the price feeds to update

target_chains/ethereum/contracts/contracts/pulse/scheduler/Scheduler.sol

@@ -328,9 +328,10 @@ abstract contract Scheduler is IScheduler, SchedulerState {
         return (subscriptionIds, subscriptionParams);
     }
 
-    // Helper functions for access control
+    // ACCESS CONTROL MODIFIERS
+
     modifier onlyPusher() {
-        // TODO
+        // TODO: we may not make this permissioned.
         _;
     }
 
@@ -349,7 +350,7 @@ abstract contract Scheduler is IScheduler, SchedulerState {
         }
 
         // If whitelist is not used, allow any reader
-        if (!_state.subscriptionParams[subscriptionId].useWhitelist) {
+        if (!_state.subscriptionParams[subscriptionId].whitelistEnabled) {
             _;
             return;
         }

target_chains/ethereum/contracts/contracts/pulse/scheduler/SchedulerState.sol

@@ -27,7 +27,7 @@ contract SchedulerState {
     struct SubscriptionParams {
         bytes32[] priceIds;
         address[] readerWhitelist;
-        bool useWhitelist;
+        bool whitelistEnabled;
         UpdateCriteria updateCriteria;
         GasConfig gasConfig;
     }

target_chains/ethereum/contracts/forge-test/PulseScheduler.t.sol

@@ -104,7 +104,7 @@ contract SchedulerTest is Test, SchedulerEvents, PulseTestUtils {
             .SubscriptionParams({
                 priceIds: priceIds,
                 readerWhitelist: readerWhitelist,
-                useWhitelist: true,
+                whitelistEnabled: true,
                 updateCriteria: updateCriteria,
                 gasConfig: gasConfig
             });
@@ -133,9 +133,9 @@ contract SchedulerTest is Test, SchedulerEvents, PulseTestUtils {
             "Whitelist length mismatch"
         );
         assertEq(
-            storedParams.useWhitelist,
+            storedParams.whitelistEnabled,
             true,
-            "useWhitelist should be true"
+            "whitelistEnabled should be true"
         );
         assertEq(
             storedParams.updateCriteria.heartbeatSeconds,
@@ -185,7 +185,7 @@ contract SchedulerTest is Test, SchedulerEvents, PulseTestUtils {
             .SubscriptionParams({
                 priceIds: newPriceIds,
                 readerWhitelist: newReaderWhitelist,
-                useWhitelist: false, // Changed from true
+                whitelistEnabled: false, // Changed from true
                 updateCriteria: newUpdateCriteria,
                 gasConfig: newGasConfig
             });
@@ -211,9 +211,9 @@ contract SchedulerTest is Test, SchedulerEvents, PulseTestUtils {
             "Whitelist length mismatch"
         );
         assertEq(
-            storedParams.useWhitelist,
+            storedParams.whitelistEnabled,
             false,
-            "useWhitelist should be false"
+            "whitelistEnabled should be false"
         );
         assertEq(
             storedParams.updateCriteria.heartbeatSeconds,
@@ -420,7 +420,7 @@ contract SchedulerTest is Test, SchedulerEvents, PulseTestUtils {
     }
 
     function testOptionalWhitelist() public {
-        // Add a subscription with useWhitelist = false
+        // Add a subscription with whitelistEnabled = false
         bytes32[] memory priceIds = createPriceIds();
         address[] memory emptyWhitelist = new address[](0);
 
@@ -441,7 +441,7 @@ contract SchedulerTest is Test, SchedulerEvents, PulseTestUtils {
             .SubscriptionParams({
                 priceIds: priceIds,
                 readerWhitelist: emptyWhitelist,
-                useWhitelist: false, // No whitelist
+                whitelistEnabled: false, // No whitelist
                 updateCriteria: updateCriteria,
                 gasConfig: gasConfig
             });
@@ -510,7 +510,7 @@ contract SchedulerTest is Test, SchedulerEvents, PulseTestUtils {
             .SubscriptionParams({
                 priceIds: priceIds,
                 readerWhitelist: emptyWhitelist,
-                useWhitelist: false,
+                whitelistEnabled: false,
                 updateCriteria: updateCriteria,
                 gasConfig: gasConfig
             });
@@ -577,7 +577,7 @@ contract SchedulerTest is Test, SchedulerEvents, PulseTestUtils {
             .SubscriptionParams({
                 priceIds: priceIds,
                 readerWhitelist: readerWhitelist,
-                useWhitelist: true,
+                whitelistEnabled: true,
                 updateCriteria: updateCriteria,
                 gasConfig: gasConfig
             });
@@ -610,7 +610,7 @@ contract SchedulerTest is Test, SchedulerEvents, PulseTestUtils {
             .SubscriptionParams({
                 priceIds: priceIds,
                 readerWhitelist: readerWhitelist,
-                useWhitelist: true,
+                whitelistEnabled: true,
                 updateCriteria: updateCriteria,
                 gasConfig: gasConfig
             });