PR comments

Author: jayantk

target_chains/ethereum/contracts/contracts/entropy/Entropy.sol

@@ -598,7 +598,7 @@ abstract contract Entropy is IEntropy, EntropyState {
                     req.sequenceNumber,
                     randomNumber,
                     false,
-                    bytes(""),
+                    ret,
                     bytes("")
                 );
                 clearRequest(provider, sequenceNumber);

target_chains/ethereum/entropy_sdk/solidity/EntropyEventsV2.sol

@@ -14,24 +14,24 @@ interface EntropyEventsV2 {
     /**
      * @notice Emitted when a new provider registers with the Entropy system
      * @param provider The address of the registered provider
-     * @param dummy Additional data field (unused)
+     * @param extraArgs A field for extra data for forward compatibility.
      */
-    event Registered(address indexed provider, bytes dummy);
+    event Registered(address indexed provider, bytes extraArgs);
 
     /**
      * @notice Emitted when a user requests a random number from a provider
      * @param provider The address of the provider handling the request
      * @param caller The address of the user requesting the random number
      * @param sequenceNumber A unique identifier for this request
      * @param userRandomNumber A random number provided by the user for additional entropy
-     * @param dummy Additional data field (unused)
+     * @param extraArgs A field for extra data for forward compatibility.
      */
     event Requested(
         address indexed provider,
         address indexed caller,
         uint64 indexed sequenceNumber,
         bytes32 userRandomNumber,
-        bytes dummy
+        bytes extraArgs
     );
 
     /**
@@ -41,101 +41,102 @@ interface EntropyEventsV2 {
      * @param sequenceNumber The unique identifier of the request
      * @param randomNumber The generated random number
      * @param callbackFailed Whether the callback to the caller failed
-     * @param callbackErrorCode If the callback failed, the error code from the callback. Note
-     * that "" often indicates an out-of-gas error.
-     * @param dummy Additional data field (unused)
+     * @param callbackReturnValue Return value from the callback. If the callback failed, this field contains
+     * the error code and any additional returned data. Note that "" often indicates an out-of-gas error.
+     * If the callback returns more than 256 bytes, only the first 256 bytes of the callback return value are included.
+     * @param extraArgs A field for extra data for forward compatibility.
      */
     event Revealed(
         address indexed provider,
         address indexed caller,
         uint64 indexed sequenceNumber,
         bytes32 randomNumber,
         bool callbackFailed,
-        bytes callbackErrorCode,
-        bytes dummy
+        bytes callbackReturnValue,
+        bytes extraArgs
     );
 
     /**
      * @notice Emitted when a provider updates their fee
      * @param provider The address of the provider updating their fee
      * @param oldFee The previous fee amount
      * @param newFee The new fee amount
-     * @param dummy Additional data field (unused)
+     * @param extraArgs A field for extra data for forward compatibility.
      */
     event ProviderFeeUpdated(
         address indexed provider,
         uint128 oldFee,
         uint128 newFee,
-        bytes dummy
+        bytes extraArgs
     );
 
     /**
      * @notice Emitted when a provider updates their default gas limit
      * @param provider The address of the provider updating their gas limit
      * @param oldDefaultGasLimit The previous default gas limit
      * @param newDefaultGasLimit The new default gas limit
-     * @param dummy Additional data field (unused)
+     * @param extraArgs A field for extra data for forward compatibility.
      */
     event ProviderDefaultGasLimitUpdated(
         address indexed provider,
         uint32 oldDefaultGasLimit,
         uint32 newDefaultGasLimit,
-        bytes dummy
+        bytes extraArgs
     );
 
     /**
      * @notice Emitted when a provider updates their URI
      * @param provider The address of the provider updating their URI
      * @param oldUri The previous URI
      * @param newUri The new URI
-     * @param dummy Additional data field (unused)
+     * @param extraArgs A field for extra data for forward compatibility.
      */
     event ProviderUriUpdated(
         address indexed provider,
         bytes oldUri,
         bytes newUri,
-        bytes dummy
+        bytes extraArgs
     );
 
     /**
      * @notice Emitted when a provider updates their fee manager address
      * @param provider The address of the provider updating their fee manager
      * @param oldFeeManager The previous fee manager address
      * @param newFeeManager The new fee manager address
-     * @param dummy Additional data field (unused)
+     * @param extraArgs A field for extra data for forward compatibility.
      */
     event ProviderFeeManagerUpdated(
         address indexed provider,
         address oldFeeManager,
         address newFeeManager,
-        bytes dummy
+        bytes extraArgs
     );
 
     /**
      * @notice Emitted when a provider updates their maximum number of hashes that can be advanced
      * @param provider The address of the provider updating their max hashes
      * @param oldMaxNumHashes The previous maximum number of hashes
      * @param newMaxNumHashes The new maximum number of hashes
-     * @param dummy Additional data field (unused)
+     * @param extraArgs A field for extra data for forward compatibility.
      */
     event ProviderMaxNumHashesAdvanced(
         address indexed provider,
         uint32 oldMaxNumHashes,
         uint32 newMaxNumHashes,
-        bytes dummy
+        bytes extraArgs
     );
 
     /**
      * @notice Emitted when a provider withdraws their accumulated fees
      * @param provider The address of the provider withdrawing fees
      * @param recipient The address receiving the withdrawn fees
      * @param withdrawnAmount The amount of fees withdrawn
-     * @param dummy Additional data field (unused)
+     * @param extraArgs A field for extra data for forward compatibility.
      */
     event Withdrawal(
         address indexed provider,
         address indexed recipient,
         uint128 withdrawnAmount,
-        bytes dummy
+        bytes extraArgs
     );
 }

target_chains/ethereum/entropy_sdk/solidity/abis/IEntropy.json

@@ -97,7 +97,7 @@
       {
         "indexed": false,
         "internalType": "bytes",
-        "name": "dummy",
+        "name": "extraArgs",
         "type": "bytes"
       }
     ],
@@ -153,7 +153,7 @@
       {
         "indexed": false,
         "internalType": "bytes",
-        "name": "dummy",
+        "name": "extraArgs",
         "type": "bytes"
       }
     ],
@@ -209,7 +209,7 @@
       {
         "indexed": false,
         "internalType": "bytes",
-        "name": "dummy",
+        "name": "extraArgs",
         "type": "bytes"
       }
     ],
@@ -265,7 +265,7 @@
       {
         "indexed": false,
         "internalType": "bytes",
-        "name": "dummy",
+        "name": "extraArgs",
         "type": "bytes"
       }
     ],
@@ -321,7 +321,7 @@
       {
         "indexed": false,
         "internalType": "bytes",
-        "name": "dummy",
+        "name": "extraArgs",
         "type": "bytes"
       }
     ],
@@ -415,7 +415,7 @@
       {
         "indexed": false,
         "internalType": "bytes",
-        "name": "dummy",
+        "name": "extraArgs",
         "type": "bytes"
       }
     ],
@@ -507,7 +507,7 @@
       {
         "indexed": false,
         "internalType": "bytes",
-        "name": "dummy",
+        "name": "extraArgs",
         "type": "bytes"
       }
     ],
@@ -708,13 +708,13 @@
       {
         "indexed": false,
         "internalType": "bytes",
-        "name": "callbackErrorCode",
+        "name": "callbackReturnValue",
         "type": "bytes"
       },
       {
         "indexed": false,
         "internalType": "bytes",
-        "name": "dummy",
+        "name": "extraArgs",
         "type": "bytes"
       }
     ],
@@ -843,7 +843,7 @@
       {
         "indexed": false,
         "internalType": "bytes",
-        "name": "dummy",
+        "name": "extraArgs",
         "type": "bytes"
       }
     ],