[solana] Post update atomic (#1210)

* Post update atomic

* Checkpoint cli

* Fix bug

* Atomic

* Cleanup

* Cleanup

* Cleanup

* Cleanup

* Comment

* Add wormhole errors

* refactor trim signatures

Author: guibescos

target_chains/solana/Cargo.lock

@@ -40,6 +40,17 @@ pub enum Action {
         #[clap(short = 'p', long, help = "Payload from Hermes")]
         payload: String,
     },
+    #[clap(about = "Post a price update from Hermes to Solana in one transaction")]
+    PostPriceUpdateAtomic {
+        #[clap(short = 'p', long, help = "Payload from Hermes")]
+        payload:      String,
+        #[clap(
+            short = 'n',
+            default_value = "5",
+            help = "Number of signatures to verify. If n >= 5 this will fail because of the transaction size limit."
+        )]
+        n_signatures: usize,
+    },
     #[clap(
         about = "Initialize a wormhole receiver contract by sequentially replaying the guardian set updates"
     )]

target_chains/solana/cli/src/cli.rs

@@ -1,7 +1,8 @@
 #![deny(warnings)]
 
-
 pub mod cli;
+
+
 use {
     anchor_client::anchor_lang::{
         InstructionData,
@@ -14,7 +15,10 @@ use {
         Action,
         Cli,
     },
-    pyth_solana_receiver::state::config::DataSource,
+    pyth_solana_receiver::{
+        state::config::DataSource,
+        PostUpdatesAtomicParams,
+    },
     pythnet_sdk::wire::v1::{
         AccumulatorUpdateData,
         MerklePriceUpdate,
@@ -102,6 +106,25 @@ fn main() -> Result<()> {
                 &merkle_price_updates[0],
             )?;
         }
+        Action::PostPriceUpdateAtomic {
+            payload,
+            n_signatures,
+        } => {
+            let rpc_client = RpcClient::new(url);
+            let payer =
+                read_keypair_file(&*shellexpand::tilde(&keypair)).expect("Keypair not found");
+
+            let (vaa, merkle_price_updates) = deserialize_accumulator_update_data(&payload)?;
+
+            process_post_price_update_atomic(
+                &rpc_client,
+                &vaa,
+                n_signatures,
+                &wormhole,
+                &payer,
+                &merkle_price_updates[0],
+            )?;
+        }
 
         Action::InitializeWormholeReceiver {} => {
             let rpc_client = RpcClient::new(url);
@@ -140,6 +163,7 @@ fn main() -> Result<()> {
                 false,
             )?;
         }
+
         Action::InitializePythReceiver {
             fee,
             emitter,
@@ -221,6 +245,55 @@ pub fn process_upgrade_guardian_set(
     Ok(())
 }
 
+pub fn process_post_price_update_atomic(
+    rpc_client: &RpcClient,
+    vaa: &[u8],
+    n_signatures: usize,
+    wormhole: &Pubkey,
+    payer: &Keypair,
+    merkle_price_update: &MerklePriceUpdate,
+) -> Result<Pubkey> {
+    let price_update_keypair = Keypair::new();
+
+    let (mut header, body): (Header, Body<&RawMessage>) = serde_wormhole::from_slice(vaa).unwrap();
+    trim_signatures(&mut header, n_signatures);
+
+    let request_compute_units_instruction: Instruction =
+        ComputeBudgetInstruction::set_compute_unit_limit(400_000);
+
+
+    let post_update_accounts = pyth_solana_receiver::accounts::PostUpdatesAtomic::populate(
+        payer.pubkey(),
+        price_update_keypair.pubkey(),
+        *wormhole,
+        header.guardian_set_index,
+    )
+    .to_account_metas(None);
+
+    let post_update_instruction = Instruction {
+        program_id: pyth_solana_receiver::id(),
+        accounts:   post_update_accounts,
+        data:       pyth_solana_receiver::instruction::PostUpdatesAtomic {
+            params: PostUpdatesAtomicParams {
+                merkle_price_update: merkle_price_update.clone(),
+                vaa:                 serde_wormhole::to_vec(&(header, body)).unwrap(),
+            },
+        }
+        .data(),
+    };
+
+    process_transaction(
+        rpc_client,
+        vec![request_compute_units_instruction, post_update_instruction],
+        &vec![payer, &price_update_keypair],
+    )?;
+    Ok(price_update_keypair.pubkey())
+}
+
+fn trim_signatures(header: &mut Header, n_signatures: usize) {
+    header.signatures = header.signatures[..(n_signatures)].to_vec();
+}
+
 fn deserialize_guardian_set(buf: &mut &[u8], legacy_guardian_set: bool) -> Result<GuardianSet> {
     if !legacy_guardian_set {
         // Skip anchor discriminator

target_chains/solana/cli/src/main.rs

@@ -21,6 +21,7 @@ pythnet-sdk = { path = "../../../../pythnet/pythnet_sdk", version = "2.0.0" }
 solana-program = "1.16.20"
 byteorder = "1.4.3"
 wormhole-core-bridge-solana = {git = "https://github.com/guibescos/wormhole", branch = "variable-sigs"}
+wormhole-raw-vaas = {version = "0.0.1-alpha.1", features = ["ruint", "on-chain"], default-features = false }
 wormhole-sdk = { git = "https://github.com/wormhole-foundation/wormhole", tag = "v2.17.1" }
 serde_wormhole = { git = "https://github.com/wormhole-foundation/wormhole", tag = "v2.17.1"}
 

target_chains/solana/programs/pyth-solana-receiver/Cargo.toml

@@ -28,4 +28,15 @@ pub enum ReceiverError {
     NonexistentGovernanceAuthorityTransferRequest,
     #[msg("Funds are insufficient to pay the receiving fee")]
     InsufficientFunds,
+    // Wormhole errors
+    #[msg("Invalid VAA version")]
+    InvalidVaaVersion,
+    #[msg("Guardian set version in the VAA doesn't match the guardian set passed")]
+    GuardianSetMismatch,
+    #[msg("Guardian index exceeds the number of guardians in the set")]
+    InvalidGuardianIndex,
+    #[msg("A VAA signature is invalid")]
+    InvalidSignature,
+    #[msg("The recovered guardian public key doesn't match the guardian set")]
+    InvalidGuardianKeyRecovery,
 }