feat: add permanent subscriptions, clean up tests

Author: tejasbadadare

target_chains/ethereum/contracts/contracts/pulse/scheduler/Scheduler.sol

@@ -98,6 +98,33 @@ abstract contract Scheduler is IScheduler, SchedulerState {
         bool wasActive = currentParams.isActive;
         bool willBeActive = newParams.isActive;
 
+        // Check for permanent subscription restrictions
+        if (currentParams.isPermanent) {
+            // Cannot disable isPermanent flag once set
+            if (!newParams.isPermanent) {
+                revert IllegalPermanentSubscriptionModification();
+            }
+
+            // Cannot remove price feeds from a permanent subscription
+            if (newParams.priceIds.length < currentParams.priceIds.length) {
+                revert IllegalPermanentSubscriptionModification();
+            }
+
+            // Check that all existing price IDs are preserved
+            for (uint i = 0; i < currentParams.priceIds.length; i++) {
+                bool found = false;
+                for (uint j = 0; j < newParams.priceIds.length; j++) {
+                    if (currentParams.priceIds[i] == newParams.priceIds[j]) {
+                        found = true;
+                        break;
+                    }
+                }
+                if (!found) {
+                    revert IllegalPermanentSubscriptionModification();
+                }
+            }
+        }
+
         // If subscription is inactive and will remain inactive, no need to validate parameters
         if (!wasActive && !willBeActive) {
             // Update subscription parameters
@@ -487,9 +514,7 @@ abstract contract Scheduler is IScheduler, SchedulerState {
 
     /// BALANCE MANAGEMENT
 
-    function addFunds(
-        uint256 subscriptionId
-    ) external payable override onlyManager(subscriptionId) {
+    function addFunds(uint256 subscriptionId) external payable override {
         if (!_state.subscriptionParams[subscriptionId].isActive) {
             revert InactiveSubscription();
         }
@@ -508,6 +533,11 @@ abstract contract Scheduler is IScheduler, SchedulerState {
             subscriptionId
         ];
 
+        // Prevent withdrawals from permanent subscriptions
+        if (params.isPermanent) {
+            revert IllegalPermanentSubscriptionModification();
+        }
+
         if (status.balanceInWei < amount) {
             revert InsufficientBalance();
         }

target_chains/ethereum/contracts/contracts/pulse/scheduler/SchedulerErrors.sol

@@ -12,6 +12,7 @@ error InvalidGasConfig();
 error PriceSlotMismatch();
 error TooManyPriceIds(uint256 provided, uint256 maximum);
 error UpdateConditionsNotMet();
+error IllegalPermanentSubscriptionModification();
 error TimestampOlderThanLastUpdate(
     uint256 providedUpdateTimestamp,
     uint256 lastUpdatedAt

target_chains/ethereum/contracts/contracts/pulse/scheduler/SchedulerState.sol

@@ -41,6 +41,7 @@ contract SchedulerState {
         address[] readerWhitelist;
         bool whitelistEnabled;
         bool isActive;
+        bool isPermanent;
         UpdateCriteria updateCriteria;
         GasConfig gasConfig;
     }