[eth] more update/parsePriceFeed optimizations (#886)

* perf(ethereum): optimize gas & bytesize by changing  some function parameters to use bytes memory

change parseWormholeMerkleHeaderNumUpdates & parsePriceFeedMessage to use bytes memory instead of
bytes calldata for function parameters

* perf(ethereum): more optimizations

use bytes memory for more functions, change parsePriceFeedMessage to use offset instead of copying a
slice

* [eth] Add unsafe calldata bytes lib (#888)

* Copy UnsafeBytesLib to UnsafeCalldataBytesLib

* [eth] Add UnsafeCalldataBytesLib and update code

---------

Co-authored-by: Ali Behjati <[email protected]>

Author: swimricky

target_chains/ethereum/contracts/contracts/libraries/MerkleTree.sol

@@ -2,7 +2,7 @@
 
 pragma solidity ^0.8.0;
 
-import "./external/UnsafeBytesLib.sol";
+import "./external/UnsafeCalldataBytesLib.sol";
 
 /**
  * @dev This library provides methods to construct and verify Merkle Tree proofs efficiently.
@@ -36,7 +36,7 @@ library MerkleTree {
         return hash(abi.encodePacked(MERKLE_NODE_PREFIX, childA, childB));
     }
 
-    /// @notice Verify Merkle Tree proof for given leaf data.
+    /// @notice Verify Merkle Tree proof for given leaf data based on data on memory.
     /// @dev To optimize gas usage, this method doesn't take the proof as a bytes array
     /// but rather takes the encoded proof and the offset of the proof in the
     /// encoded proof array possibly containing multiple proofs. Also, the method
@@ -45,20 +45,23 @@ library MerkleTree {
     /// that the `encodedProof` is long enough to contain the proof and the
     /// `proofOffset` is not out of bound.
     function isProofValid(
-        bytes memory encodedProof,
+        bytes calldata encodedProof,
         uint proofOffset,
         bytes20 root,
-        bytes memory leafData
+        bytes calldata leafData
     ) internal pure returns (bool valid, uint endOffset) {
         unchecked {
             bytes20 currentDigest = MerkleTree.leafHash(leafData);
 
-            uint8 proofSize = UnsafeBytesLib.toUint8(encodedProof, proofOffset);
+            uint8 proofSize = UnsafeCalldataBytesLib.toUint8(
+                encodedProof,
+                proofOffset
+            );
             proofOffset += 1;
 
             for (uint i = 0; i < proofSize; i++) {
                 bytes20 siblingDigest = bytes20(
-                    UnsafeBytesLib.toAddress(encodedProof, proofOffset)
+                    UnsafeCalldataBytesLib.toAddress(encodedProof, proofOffset)
                 );
                 proofOffset += 20;
 

target_chains/ethereum/contracts/contracts/libraries/external/UnsafeCalldataBytesLib.sol

@@ -0,0 +1,139 @@
+// SPDX-License-Identifier: Unlicense
+/*
+ * @title Solidity Bytes Arrays Utils
+ * @author Gonçalo Sá <[email protected]>
+ *
+ * @dev Bytes tightly packed arrays utility library for ethereum contracts written in Solidity.
+ *      The library lets you concatenate, slice and type cast bytes arrays both in memory and storage.
+ *
+ * @notice This is the **unsafe** version of BytesLib which removed all the checks (out of bound, ...)
+ * to be more gas efficient.
+ */
+pragma solidity >=0.8.0 <0.9.0;
+
+library UnsafeCalldataBytesLib {
+    function slice(
+        bytes calldata _bytes,
+        uint256 _start,
+        uint256 _length
+    ) internal pure returns (bytes calldata) {
+        return _bytes[_start:_start + _length];
+    }
+
+    function toAddress(
+        bytes calldata _bytes,
+        uint256 _start
+    ) internal pure returns (address) {
+        address tempAddress;
+
+        assembly {
+            tempAddress := shr(96, calldataload(add(_bytes.offset, _start)))
+        }
+
+        return tempAddress;
+    }
+
+    function toUint8(
+        bytes calldata _bytes,
+        uint256 _start
+    ) internal pure returns (uint8) {
+        uint8 tempUint;
+
+        assembly {
+            tempUint := shr(248, calldataload(add(_bytes.offset, _start)))
+        }
+
+        return tempUint;
+    }
+
+    function toUint16(
+        bytes calldata _bytes,
+        uint256 _start
+    ) internal pure returns (uint16) {
+        uint16 tempUint;
+
+        assembly {
+            tempUint := shr(240, calldataload(add(_bytes.offset, _start)))
+        }
+
+        return tempUint;
+    }
+
+    function toUint32(
+        bytes calldata _bytes,
+        uint256 _start
+    ) internal pure returns (uint32) {
+        uint32 tempUint;
+
+        assembly {
+            tempUint := shr(224, calldataload(add(_bytes.offset, _start)))
+        }
+
+        return tempUint;
+    }
+
+    function toUint64(
+        bytes calldata _bytes,
+        uint256 _start
+    ) internal pure returns (uint64) {
+        uint64 tempUint;
+
+        assembly {
+            tempUint := shr(192, calldataload(add(_bytes.offset, _start)))
+        }
+
+        return tempUint;
+    }
+
+    function toUint96(
+        bytes calldata _bytes,
+        uint256 _start
+    ) internal pure returns (uint96) {
+        uint96 tempUint;
+
+        assembly {
+            tempUint := shr(160, calldataload(add(_bytes.offset, _start)))
+        }
+
+        return tempUint;
+    }
+
+    function toUint128(
+        bytes calldata _bytes,
+        uint256 _start
+    ) internal pure returns (uint128) {
+        uint128 tempUint;
+
+        assembly {
+            tempUint := shr(128, calldataload(add(_bytes.offset, _start)))
+        }
+
+        return tempUint;
+    }
+
+    function toUint256(
+        bytes calldata _bytes,
+        uint256 _start
+    ) internal pure returns (uint256) {
+        uint256 tempUint;
+
+        assembly {
+            tempUint := calldataload(add(_bytes.offset, _start))
+        }
+
+        return tempUint;
+    }
+
+    function toBytes32(
+        bytes calldata _bytes,
+        uint256 _start
+    ) internal pure returns (bytes32) {
+        bytes32 tempBytes32;
+
+        assembly {
+            tempBytes32 := calldataload(add(_bytes.offset, _start))
+        }
+
+        return tempBytes32;
+    }
+}

target_chains/ethereum/contracts/contracts/pyth/Pyth.sol

@@ -107,7 +107,8 @@ abstract contract Pyth is
         for (uint i = 0; i < updateData.length; i++) {
             if (
                 updateData[i].length > 4 &&
-                UnsafeBytesLib.toUint32(updateData[i], 0) == ACCUMULATOR_MAGIC
+                UnsafeCalldataBytesLib.toUint32(updateData[i], 0) ==
+                ACCUMULATOR_MAGIC
             ) {
                 (
                     uint offset,
@@ -447,13 +448,16 @@ abstract contract Pyth is
         override
         returns (PythStructs.PriceFeed[] memory priceFeeds)
     {
+        {
+            uint requiredFee = getUpdateFee(updateData);
+            if (msg.value < requiredFee) revert PythErrors.InsufficientFee();
+        }
         unchecked {
-            uint totalNumUpdates = 0;
             priceFeeds = new PythStructs.PriceFeed[](priceIds.length);
             for (uint i = 0; i < updateData.length; i++) {
                 if (
                     updateData[i].length > 4 &&
-                    UnsafeBytesLib.toUint32(updateData[i], 0) ==
+                    UnsafeCalldataBytesLib.toUint32(updateData[i], 0) ==
                     ACCUMULATOR_MAGIC
                 ) {
                     uint offset;
@@ -473,7 +477,7 @@ abstract contract Pyth is
 
                     bytes20 digest;
                     uint8 numUpdates;
-                    bytes memory encoded;
+                    bytes calldata encoded;
                     (
                         offset,
                         digest,
@@ -525,7 +529,6 @@ abstract contract Pyth is
                             }
                         }
                     }
-                    totalNumUpdates += numUpdates;
                     if (offset != encoded.length)
                         revert PythErrors.InvalidUpdateData();
                 } else {
@@ -600,7 +603,6 @@ abstract contract Pyth is
 
                         index += attestationSize;
                     }
-                    totalNumUpdates += 1;
                 }
             }
 
@@ -609,12 +611,6 @@ abstract contract Pyth is
                     revert PythErrors.PriceFeedNotFoundWithinRange();
                 }
             }
-
-            {
-                uint requiredFee = getTotalFee(totalNumUpdates);
-                if (msg.value < requiredFee)
-                    revert PythErrors.InsufficientFee();
-            }
         }
     }