feat: make updateSubscription payable

Author: tejasbadadare

target_chains/ethereum/contracts/contracts/pulse/IScheduler.sol

@@ -36,15 +36,16 @@ interface IScheduler is SchedulerEvents {
 
     /**
      * @notice Updates an existing subscription
-     * @dev You can activate or deactivate a subscription by setting isActive to true or false.
-     * @dev Reactivating a subscription requires the subscription to hold at least the minimum balance (calculated by getMinimumBalance()).
+     * @dev You can activate or deactivate a subscription by setting isActive to true or false. Reactivating a subscription
+     *      requires the subscription to hold at least the minimum balance (calculated by getMinimumBalance()).
+     * @dev Any Ether sent with this call (`msg.value`) will be added to the subscription's balance before processing the update.
      * @param subscriptionId The ID of the subscription to update
      * @param newSubscriptionParams The new parameters for the subscription
      */
     function updateSubscription(
         uint256 subscriptionId,
         SchedulerState.SubscriptionParams calldata newSubscriptionParams
-    ) external;
+    ) external payable;
 
     /**
      * @notice Updates price feeds for a subscription.

target_chains/ethereum/contracts/contracts/pulse/Scheduler.sol

@@ -73,14 +73,17 @@ abstract contract Scheduler is IScheduler, SchedulerState {
     function updateSubscription(
         uint256 subscriptionId,
         SubscriptionParams memory newParams
-    ) external override onlyManager(subscriptionId) {
+    ) external payable override onlyManager(subscriptionId) {
         SubscriptionStatus storage currentStatus = _state.subscriptionStatuses[
             subscriptionId
         ];
         SubscriptionParams storage currentParams = _state.subscriptionParams[
             subscriptionId
         ];
 
+        // Add incoming funds to balance
+        currentStatus.balanceInWei += msg.value;
+
         // Updates to permanent subscriptions are not allowed
         if (currentParams.isPermanent) {
             revert CannotUpdatePermanentSubscription();

target_chains/ethereum/contracts/forge-test/PulseScheduler.t.sol

@@ -1133,17 +1133,16 @@ contract SchedulerTest is Test, SchedulerEvents, PulseSchedulerTestUtils {
         vm.expectRevert(abi.encodeWithSelector(InsufficientBalance.selector));
         scheduler.updateSubscription(subscriptionId, newParams);
 
-        // Action 2: Add enough funds to meet the new minimum balance
+        // Action 2: Supply enough funds to the updateSubscription call to meet the new minimum balance
         uint256 newMinimumBalance = scheduler.getMinimumBalance(newNumFeeds);
         uint256 requiredFunds = newMinimumBalance - initialMinimumBalance;
-        scheduler.addFunds{value: requiredFunds}(subscriptionId);
 
-        // Verification 2: Update should now succeed
-        vm.expectEmit();
-        emit SubscriptionUpdated(subscriptionId);
-        scheduler.updateSubscription(subscriptionId, newParams);
+        scheduler.updateSubscription{value: requiredFunds}(
+            subscriptionId,
+            newParams
+        );
 
-        // Verify the number of price IDs was updated
+        // Verification 2: Update should now succeed
         (SchedulerState.SubscriptionParams memory updatedParams, ) = scheduler
             .getSubscription(subscriptionId);
         assertEq(
@@ -1173,11 +1172,6 @@ contract SchedulerTest is Test, SchedulerEvents, PulseSchedulerTestUtils {
         newParams_deact.isActive = false; // Deactivate
 
         // Action 3: Update (should succeed even with insufficient funds for 4 feeds)
-        vm.expectEmit();
-        emit SubscriptionDeactivated(subId_deact);
-        vm.expectEmit();
-        emit SubscriptionUpdated(subId_deact);
-        // No revert expected here
         scheduler.updateSubscription(subId_deact, newParams_deact);
 
         // Verification 3: Subscription should be inactive and have 4 feeds