g

Author: tejasbadadare

target_chains/ethereum/contracts/contracts/pulse/scheduler/IScheduler.sol

@@ -125,7 +125,7 @@ interface IScheduler is SchedulerEvents {
      * @param maxResults The maximum number of results to return
      * @return subscriptionIds Array of active subscription IDs
      * @return subscriptionParams Array of subscription parameters for each active subscription
-     * @return totalCount Total returned number of active subscriptions
+     * @return totalCount Total number of active subscriptions
      */
     function getActiveSubscriptions(
         uint256 startIndex,

target_chains/ethereum/contracts/contracts/pulse/scheduler/Scheduler.sol

@@ -518,7 +518,7 @@ abstract contract Scheduler is IScheduler, SchedulerState {
      */
     function getMinimumBalance(
         uint8 numPriceFeeds
-    ) external view override returns (uint256 minimumBalance) {
+    ) external pure override returns (uint256 minimumBalance) {
         // Simple implementation - minimum balance is 0.01 ETH per price feed
         return numPriceFeeds * 0.01 ether;
     }

target_chains/ethereum/contracts/forge-test/PulseScheduler.t.sol

@@ -30,7 +30,8 @@ contract MockReader {
         uint256 subscriptionId,
         bytes32[] memory priceIds
     ) external view returns (PythStructs.Price[] memory) {
-        return IScheduler(_scheduler).getEmaPriceUnsafe(subscriptionId, priceIds);
+        return
+            IScheduler(_scheduler).getEmaPriceUnsafe(subscriptionId, priceIds);
     }
 
     function verifyPriceFeeds(
@@ -49,7 +50,8 @@ contract MockReader {
             if (
                 actualPrices[i].price != expectedFeeds[i].price.price ||
                 actualPrices[i].conf != expectedFeeds[i].price.conf ||
-                actualPrices[i].publishTime != expectedFeeds[i].price.publishTime
+                actualPrices[i].publishTime !=
+                expectedFeeds[i].price.publishTime
             ) {
                 return false;
             }
@@ -731,7 +733,7 @@ contract SchedulerTest is Test, SchedulerEvents, PulseTestUtils {
             "Price feeds verification failed"
         );
     }
-    
+
     function testGetEmaPriceUnsafe() public {
         // First add a subscription, funds, and update price feeds
         uint256 subscriptionId = addTestSubscription();
@@ -743,15 +745,15 @@ contract SchedulerTest is Test, SchedulerEvents, PulseTestUtils {
         PythStructs.PriceFeed[] memory priceFeeds = createMockPriceFeeds(
             publishTime
         );
-        
+
         // Ensure EMA prices are set in the mock price feeds
         for (uint i = 0; i < priceFeeds.length; i++) {
             priceFeeds[i].emaPrice.price = priceFeeds[i].price.price * 2; // Make EMA price different for testing
             priceFeeds[i].emaPrice.conf = priceFeeds[i].price.conf;
             priceFeeds[i].emaPrice.publishTime = publishTime;
             priceFeeds[i].emaPrice.expo = priceFeeds[i].price.expo;
         }
-        
+
         mockParsePriceFeedUpdates(pyth, priceFeeds);
         bytes[] memory updateData = createMockUpdateData(priceFeeds);
 
@@ -771,7 +773,7 @@ contract SchedulerTest is Test, SchedulerEvents, PulseTestUtils {
             priceIds.length,
             "Should return all EMA prices"
         );
-        
+
         // Verify EMA price values
         for (uint i = 0; i < emaPrices.length; i++) {
             assertEq(
@@ -841,11 +843,7 @@ contract SchedulerTest is Test, SchedulerEvents, PulseTestUtils {
             3,
             "Should have 3 active subscription params"
         );
-        assertEq(
-            totalCount,
-            3,
-            "Total count should be 3"
-        );
+        assertEq(totalCount, 3, "Total count should be 3");
 
         // Verify subscription params
         for (uint i = 0; i < activeIds.length; i++) {
@@ -866,38 +864,50 @@ contract SchedulerTest is Test, SchedulerEvents, PulseTestUtils {
                 "Heartbeat seconds mismatch"
             );
         }
-        
+
         // Test pagination - get only the first subscription
         vm.prank(owner);
         (
             uint256[] memory firstPageIds,
             SchedulerState.SubscriptionParams[] memory firstPageParams,
             uint256 firstPageTotal
         ) = scheduler.getActiveSubscriptions(0, 1);
-        
-        assertEq(firstPageIds.length, 1, "Should have 1 subscription in first page");
+
+        assertEq(
+            firstPageIds.length,
+            1,
+            "Should have 1 subscription in first page"
+        );
         assertEq(firstPageTotal, 3, "Total count should still be 3");
-        
+
         // Test pagination - get the second page
         vm.prank(owner);
         (
             uint256[] memory secondPageIds,
             SchedulerState.SubscriptionParams[] memory secondPageParams,
             uint256 secondPageTotal
         ) = scheduler.getActiveSubscriptions(1, 2);
-        
-        assertEq(secondPageIds.length, 2, "Should have 2 subscriptions in second page");
+
+        assertEq(
+            secondPageIds.length,
+            2,
+            "Should have 2 subscriptions in second page"
+        );
         assertEq(secondPageTotal, 3, "Total count should still be 3");
-        
+
         // Test pagination - start index beyond total count
         vm.prank(owner);
         (
             uint256[] memory emptyPageIds,
             SchedulerState.SubscriptionParams[] memory emptyPageParams,
             uint256 emptyPageTotal
         ) = scheduler.getActiveSubscriptions(10, 10);
-        
-        assertEq(emptyPageIds.length, 0, "Should have 0 subscriptions when start index is beyond total");
+
+        assertEq(
+            emptyPageIds.length,
+            0,
+            "Should have 0 subscriptions when start index is beyond total"
+        );
         assertEq(emptyPageTotal, 3, "Total count should still be 3");
     }