[xc-admin-frontend] Stop reloading proposals when you connect a wallet (#670)

* Make wallet simpler

* Fix

Author: guibescos

governance/xc_admin/packages/xc_admin_frontend/hooks/useMultisig.ts

@@ -1,8 +1,10 @@
 import { Wallet } from '@coral-xyz/anchor'
+import NodeWallet from '@coral-xyz/anchor/dist/cjs/nodewallet'
 import {
   AccountMeta,
   Cluster,
   Connection,
+  Keypair,
   PublicKey,
   Transaction,
 } from '@solana/web3.js'
@@ -60,7 +62,6 @@ const getSortedProposals = async (
 }
 
 export const useMultisig = (wallet: Wallet): MultisigHookData => {
-  const connectionRef = useRef<Connection>()
   const { cluster } = useContext(ClusterContext)
   const [isLoading, setIsLoading] = useState(true)
   const [error, setError] = useState(null)
@@ -85,6 +86,22 @@ export const useMultisig = (wallet: Wallet): MultisigHookData => {
     setError(null)
   }, [urlsIndex, cluster])
 
+  useEffect(() => {
+    const urls = pythClusterApiUrls(getMultisigCluster(cluster))
+    const connection = new Connection(urls[urlsIndex].rpcUrl, {
+      commitment: 'confirmed',
+      wsEndpoint: urls[urlsIndex].wsUrl,
+    })
+    if (wallet) {
+      setSquads(
+        new SquadsMesh({
+          connection,
+          wallet,
+        })
+      )
+    }
+  }, [wallet, urlsIndex, cluster])
+
   useEffect(() => {
     let cancelled = false
     const urls = pythClusterApiUrls(getMultisigCluster(cluster))
@@ -93,42 +110,24 @@ export const useMultisig = (wallet: Wallet): MultisigHookData => {
       wsEndpoint: urls[urlsIndex].wsUrl,
     })
 
-    connectionRef.current = connection
     ;(async () => {
       try {
         // mock wallet to allow users to view proposals without connecting their wallet
-        const signTransaction = () =>
-          new Promise<Transaction>((resolve) => {
-            resolve(new Transaction())
-          })
-        const signAllTransactions = () =>
-          new Promise<Transaction[]>((resolve) => {
-            resolve([new Transaction()])
-          })
-        const squads = wallet
-          ? new SquadsMesh({
-              connection,
-              wallet,
-            })
-          : new SquadsMesh({
-              connection,
-              wallet: {
-                signTransaction: () => signTransaction(),
-                signAllTransactions: () => signAllTransactions(),
-                publicKey: new PublicKey(0),
-              },
-            })
+        const readOnlySquads = new SquadsMesh({
+          connection,
+          wallet: new NodeWallet(new Keypair()),
+        })
         if (cancelled) return
         setUpgradeMultisigAccount(
-          await squads.getMultisig(
+          await readOnlySquads.getMultisig(
             UPGRADE_MULTISIG[getMultisigCluster(cluster)]
           )
         )
         try {
           if (cancelled) return
           // DELETE THIS TRY CATCH ONCE THIS MULTISIG EXISTS EVERYWHERE
           setpriceFeedMultisigAccount(
-            await squads.getMultisig(
+            await readOnlySquads.getMultisig(
               PRICE_FEED_MULTISIG[getMultisigCluster(cluster)]
             )
           )
@@ -140,19 +139,19 @@ export const useMultisig = (wallet: Wallet): MultisigHookData => {
         if (cancelled) return
         setUpgradeMultisigProposals(
           await getSortedProposals(
-            squads,
+            readOnlySquads,
             UPGRADE_MULTISIG[getMultisigCluster(cluster)]
           )
         )
         try {
           if (cancelled) return
           // DELETE THIS TRY CATCH ONCE THIS MULTISIG EXISTS EVERYWHERE
           const sortedPriceFeedMultisigProposals = await getSortedProposals(
-            squads,
+            readOnlySquads,
             PRICE_FEED_MULTISIG[getMultisigCluster(cluster)]
           )
           const allProposalsIxs = await getManyProposalsInstructions(
-            squads,
+            readOnlySquads,
             sortedPriceFeedMultisigProposals
           )
           const multisigParser = MultisigParser.fromCluster(
@@ -199,7 +198,6 @@ export const useMultisig = (wallet: Wallet): MultisigHookData => {
           setpriceFeedMultisigProposals([])
         }
 
-        setSquads(squads)
         setIsLoading(false)
       } catch (e) {
         console.log(e)
@@ -221,7 +219,7 @@ export const useMultisig = (wallet: Wallet): MultisigHookData => {
     return () => {
       cancelled = true
     }
-  }, [urlsIndex, cluster, wallet])
+  }, [urlsIndex, cluster])
 
   return {
     isLoading,