fix: improve error handling and logging in proposer server; refactor LazerExecute instruction creation

Author: cctdaniel

governance/xc_admin/packages/proposer_server/src/index.ts

@@ -90,8 +90,10 @@ app.post("/api/propose", async (req: Request, res: Response) => {
     res.status(200).json({ proposalPubkey: proposalPubkey });
   } catch (error) {
     if (error instanceof Error) {
+      console.error(error);
       res.status(500).json(error.message);
     } else {
+      console.error(error);
       res.status(500).json("An unknown error occurred");
     }
   }

governance/xc_admin/packages/xc_admin_common/src/programs/lazer/lazer_functions.ts

@@ -1,21 +1,18 @@
 import { PublicKey, TransactionInstruction } from "@solana/web3.js";
 import { PythCluster } from "@pythnetwork/client";
 import {
-  ValidationResult,
   LazerValidationResult,
   ProgramType,
   LazerConfig,
   LazerState,
   LazerFeedMetadata,
-  LazerFeed,
-  LazerPublisher,
   ShardChange,
   FeedChange,
   PublisherChange,
   LazerConfigChanges,
 } from "../types";
 import { pyth_lazer_transaction } from "@pythnetwork/pyth-lazer-state-sdk/governance";
-import { ChainName, LazerExecute } from "../..";
+import { ChainName, LazerExecute, WORMHOLE_ADDRESS } from "../..";
 
 /**
  * Converts LazerFeedMetadata to protobuf IMap format using protobufjs fromObject
@@ -605,11 +602,13 @@ export async function generateInstructions(
     }
   }
 
-  // Create a single LazerExecute instruction with all directives if we have any
-  if (directives.length > 0) {
+  // Create one LazerExecute instruction per directive
+  for (let i = 0; i < directives.length; i++) {
+    const directive = directives[i];
+
     const lazerExecute = new LazerExecute(
       targetChainId,
-      directives,
+      [directive], // Single directive per instruction
       undefined, // minExecutionTimestamp
       undefined, // maxExecutionTimestamp
       undefined, // governanceSequenceNo

governance/xc_admin/packages/xc_admin_frontend/components/programs/PythLazer.tsx

@@ -23,6 +23,7 @@ import {
 import { capitalizeFirstLetter } from '../../utils/capitalizeFirstLetter'
 import { generateInstructions } from '@pythnetwork/xc-admin-common/lib/programs/lazer/lazer_functions'
 import { useMultisigContext } from '../../contexts/MultisigContext'
+import axios from 'axios'
 
 interface PythLazerProps {
   proposerServerUrl: string
@@ -363,7 +364,7 @@ const ModalContent: React.FC<ModalContentProps> = ({
 }
 
 const PythLazer = ({
-  proposerServerUrl: _proposerServerUrl,
+  proposerServerUrl: proposerServerUrl,
 }: PythLazerProps) => {
   const { dataIsLoading, lazerState } = usePythContext()
   const { cluster } = useContext(ClusterContext)
@@ -465,17 +466,20 @@ const PythLazer = ({
 
         console.log('Generated instructions:', instructions)
 
-        // In a real implementation, this would send the proposal to the server
-        await new Promise((resolve) => setTimeout(resolve, 2000)) // Mock delay
-
-        // Close the modal and show success notification
-        setIsModalOpen(false)
-        toast.success('Proposal sent successfully!')
+        const response = await axios.post(proposerServerUrl + '/api/propose', {
+          instructions,
+          cluster,
+        })
+        const { proposalPubkey } = response.data
+        toast.success(`Proposal sent! 🚀 Proposal Pubkey: ${proposalPubkey}`)
+        setIsSendProposalButtonLoading(false)
+        closeModal()
       } catch (error) {
-        if (error instanceof Error) {
+        if (axios.isAxiosError(error) && error.response) {
+          toast.error(capitalizeFirstLetter(error.response.data))
+        } else if (error instanceof Error) {
           toast.error(capitalizeFirstLetter(error.message))
         }
-      } finally {
         setIsSendProposalButtonLoading(false)
       }
     }

lazer/state_sdk/js/package.json

@@ -40,5 +40,7 @@
     "oracle"
   ],
   "license": "Apache-2.0",
-  "dependencies": {}
+  "dependencies": {
+    "protobufjs": "^7.5.3"
+  }
 }