feat: enhance fee charging logic for TWAP updates to improve user experience

cctdaniel · cctdaniel · commit 671c6c327773 · 2025-04-08T14:36:19.000+09:00
diff --git a/target_chains/ethereum/contracts/contracts/pyth/Pyth.sol b/target_chains/ethereum/contracts/contracts/pyth/Pyth.sol
@@ -373,11 +373,14 @@ abstract contract Pyth is
         if (updateData.length != 2) {
             revert PythErrors.InvalidUpdateData();
         }
+        // We only charge fee for 1 update even though we need 2 updates to derive TWAP.
+        // This is for better UX since user's intention is to get a single TWAP price.
         uint requiredFee = getUpdateFee(updateData[0]);
 
         if (requiredFee != getUpdateFee(updateData[1])) {
             revert PythErrors.InvalidUpdateData();
         }
+
         if (msg.value < requiredFee) revert PythErrors.InsufficientFee();
 
         unchecked {

Original file line number	Diff line number	Diff line change
`@@ -373,11 +373,14 @@ abstract contract Pyth is`
`373`	`373`	`if (updateData.length != 2) {`
`374`	`374`	`revert PythErrors.InvalidUpdateData();`
`375`	`375`	`}`
	`376`	`+ // We only charge fee for 1 update even though we need 2 updates to derive TWAP.`
	`377`	`+ // This is for better UX since user's intention is to get a single TWAP price.`
`376`	`378`	`uint requiredFee = getUpdateFee(updateData[0]);`
`377`	`379`
`378`	`380`	`if (requiredFee != getUpdateFee(updateData[1])) {`
`379`	`381`	`revert PythErrors.InvalidUpdateData();`
`380`	`382`	`}`
	`383`	`+`
`381`	`384`	`if (msg.value < requiredFee) revert PythErrors.InsufficientFee();`
`382`	`385`
`383`	`386`	`unchecked {`