fix: access control, add todos

tejasbadadare · tejasbadadare · commit 760555555350 · 2025-04-09T17:31:13.000-07:00
diff --git a/target_chains/ethereum/contracts/contracts/pulse/scheduler/Scheduler.sol b/target_chains/ethereum/contracts/contracts/pulse/scheduler/Scheduler.sol
@@ -275,10 +275,6 @@ abstract contract Scheduler is IScheduler, SchedulerState {
             subscriptionId
         ];
 
-        if (!status.isActive) {
-            revert InactiveSubscription();
-        }
-
         if (status.balanceInWei < amount) {
             revert InsufficientBalance();
         }
diff --git a/target_chains/ethereum/contracts/contracts/pulse/scheduler/SchedulerState.sol b/target_chains/ethereum/contracts/contracts/pulse/scheduler/SchedulerState.sol
@@ -54,5 +54,11 @@ contract SchedulerState {
         uint32 heartbeatSeconds;
         bool updateOnDeviation;
         uint32 deviationThresholdBps;
+
+        // TODO: add updateOnConfidenceRatio?
+
+        // TODO: add "early update" support? i.e. update all feeds when at least one feed
+        //          meets the triggering conditions, rather than waiting for all feeds
+        //          to meet the conditions
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -54,5 +54,11 @@ contract SchedulerState {`
`54`	`54`	`uint32 heartbeatSeconds;`
`55`	`55`	`bool updateOnDeviation;`
`56`	`56`	`uint32 deviationThresholdBps;`
	`57`	`+`
	`58`	`+ // TODO: add updateOnConfidenceRatio?`
	`59`	`+`
	`60`	`+ // TODO: add "early update" support? i.e. update all feeds when at least one feed`
	`61`	`+ // meets the triggering conditions, rather than waiting for all feeds`
	`62`	`+ // to meet the conditions`
`57`	`63`	`}`
`58`	`64`	`}`