Skip to content

Commit 8528712

Browse files
chore(styles): improve mobile layout in footer, modify spacing, and enhance support documentation link appearance
1 parent 6f89b7e commit 8528712

File tree

6 files changed

+46
-40
lines changed

6 files changed

+46
-40
lines changed

apps/insights/src/components/Root/footer.module.scss

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,10 @@
77
// XL
88
padding: theme.spacing(8) 0;
99

10+
@include theme.mobile {
11+
padding-bottom: theme.spacing(20);
12+
}
13+
1014
// bg-beige-100 sm:border-t sm:border-stone-300
1115

1216
.topContent {
@@ -84,6 +88,7 @@
8488
justify-content: flex-end;
8589
gap: theme.spacing(2);
8690

91+
8792
// justify-between
8893
}
8994
}
@@ -96,11 +101,6 @@
96101
flex-flow: row nowrap;
97102
justify-content: space-between;
98103

99-
@media screen and (max-width: theme.breakpoint("sm")) {
100-
flex-flow: column nowrap;
101-
align-items: flex-start;
102-
}
103-
104104
// "flex-col
105105

106106
@include theme.max-width;

apps/insights/src/components/Root/footer.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
import { ArrowSquareOut } from "@phosphor-icons/react/dist/ssr/ArrowSquareOut";
12
import {
23
type Props as ButtonProps,
34
Button,
@@ -21,10 +22,10 @@ export const Footer = () => (
2122
<div className={styles.divider} />
2223
<div className={styles.help}>
2324
<SupportDrawer>
24-
<Link>Help</Link>
25+
<Link>Support</Link>
2526
</SupportDrawer>
2627
<Link href="https://docs.pyth.network" target="_blank">
27-
Documentation
28+
Documentation <ArrowSquareOut />
2829
</Link>
2930
</div>
3031
</div>

apps/insights/src/components/Root/header.module.scss

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,10 @@
2525
.logoLink {
2626
padding: theme.spacing(3);
2727
color: theme.color("foreground");
28-
position: absolute;
29-
left: -#{theme.spacing(16)};
30-
@include theme.mobile {
31-
left: 0;
32-
position: relative;
28+
29+
@include theme.desktop {
30+
position: absolute;
31+
left: -#{theme.spacing(16)};
3332
}
3433

3534
.logoWrapper {
@@ -65,12 +64,15 @@
6564
@include theme.row;
6665

6766
.themeSwitch {
68-
position: absolute;
69-
right: -#{theme.spacing(16)};
70-
top: 0;
67+
position: relative;
7168
@include theme.mobile {
7269
display: none;
7370
}
71+
@include theme.desktop {
72+
display: block;
73+
position: absolute;
74+
right: -#{theme.spacing(16)};
75+
}
7476
}
7577
}
7678
// Reason: you can absolute position relatively to a container and disable this behavior on mobile

packages/component-library/src/Drawer/index.module.scss

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,11 @@
2727
border-radius: 0;
2828
border: none;
2929
padding-bottom: 0;
30+
// Remove if we don't want a gap on the top
31+
// Will require to change the animation direction
32+
// top: 5rem;
33+
// border-top-left-radius: theme.border-radius("2xl");
34+
// border-top-right-radius: theme.border-radius("2xl");
3035
}
3136

3237
.heading {

packages/component-library/src/MainNavTabs/index.module.scss

Lines changed: 19 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,28 @@
55

66
@include theme.row;
77

8+
@include theme.mobile {
9+
position: fixed;
10+
bottom: 0;
11+
left: 0;
12+
right: 0;
13+
z-index: 900;
14+
padding: 0.5rem;
15+
display: flex;
16+
justify-content: space-between;
17+
align-items: center;
18+
height: 3rem;
19+
border-top: 1px solid theme.color("border");
20+
background: theme.color("background", "primary");
21+
}
22+
823
.tab {
924
position: relative;
1025
outline: none;
26+
@include theme.mobile {
27+
flex-grow: 1;
28+
text-align: center;
29+
}
1130

1231
.bubble {
1332
position: absolute;
@@ -59,25 +78,3 @@
5978
}
6079
}
6180
}
62-
63-
64-
@include theme.mobile {
65-
.mainNavTabs {
66-
background: red;
67-
position: fixed;
68-
bottom: 0;
69-
left: 0;
70-
right: 0;
71-
z-index: 900;
72-
padding: 0.5rem;
73-
display: flex;
74-
justify-content: space-between;
75-
align-items: center;
76-
height: 3rem;
77-
border-top: 1px solid theme.color("border");
78-
}
79-
.tab {
80-
flex-grow: 1;
81-
text-align: center;
82-
}
83-
}

packages/component-library/src/theme.scss

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -83,10 +83,11 @@ $border-radius: (
8383
$brakpoints: (
8484
"xs": 480px,
8585
"sm": 720px,
86-
"md": 768px,
86+
"md": 960px,
8787
"lg": 1024px,
8888
"xl": 1280px,
8989
"2xl": 1536px,
90+
"3xl": 1720px,
9091
);
9192

9293
@function breakpoint($breakpoint) {
@@ -95,7 +96,7 @@ $brakpoints: (
9596

9697

9798
@mixin mobile() {
98-
@media screen and (max-width: breakpoint("sm")) {
99+
@media screen and (max-width: breakpoint("md")) {
99100
@content;
100101
}
101102
}
@@ -107,7 +108,7 @@ $brakpoints: (
107108
}
108109

109110
@mixin desktop() {
110-
@media screen and (min-width: breakpoint("xl")) {
111+
@media screen and (min-width: breakpoint("3xl")) {
111112
@content;
112113
}
113114
}

0 commit comments

Comments
 (0)