Merge pull request #1775 from cprussin/only-require-walletconnect-id-in-prod

fix(api-refernece) only require WALLETCONNECT_PROJECT_ID in prod

Author: cprussin

apps/api-reference/src/components/EvmProvider/index.tsx

@@ -11,7 +11,7 @@ import { metadata } from "../../metadata";
 
 type EvmProviderProps = {
   children: ReactNode;
-  walletConnectProjectId: string;
+  walletConnectProjectId?: string | undefined;
 };
 
 export const EvmProvider = ({
@@ -28,11 +28,11 @@ export const EvmProvider = ({
           [arbitrum.id]: http(),
           [sepolia.id]: http(),
         },
-        walletConnectProjectId,
         appName: metadata.applicationName,
         appDescription: metadata.description,
         appUrl: metadata.metadataBase.toString(),
         appIcon: metadata.icons.apple.url,
+        walletConnectProjectId: walletConnectProjectId ?? "",
       }),
     )}
   >

apps/api-reference/src/server-config.ts

@@ -16,37 +16,6 @@ const demand = (key: string): string => {
   }
 };
 
-/**
- * Indicates that we're running in a github actions workflow.
- */
-export const IS_GITHUB_ACTIONS = process.env.GITHUB_ACTIONS === "true";
-
-/**
- * Throw if the env var `key` is not set, unless we're running in github
- * actions.  If running in GHA, then allow the variable to be unset and return
- * an empty string if so.
- *
- * This is useful because for some variables, we want an invariant that the
- * value is always present.  However, we don't necessarily need the value just
- * to run code checks, some of which require a build, we don't want to
- * expose the secret to GHA unnecessarily, and we don't want to have to.
- *
- * So, in effect, variables marked with this will be asserted to be present in
- * Vercel or in local dev, and will type check as `string`, but will not throw
- * when running code checks in GHA.
- *
- * Note we use `IS_GITHUB_ACTIONS` and not e.g. `process.env.CI` here because
- * both Vercel and Github Actions set `process.env.CI`, and we specifically want
- * to only allow these variables to be nonpresent only if running a build just
- * for running code checks.  Any build that will actually serve traffic must
- * have these variables set.  Github Actions is the only environment that is
- * exclusively used for running checks, so semantically this is correct, but
- * this would need to be updated if we change infrastructure.
- */
-const demandExceptGHA = IS_GITHUB_ACTIONS
-  ? (key: string) => process.env[key] ?? ""
-  : demand;
-
 /**
  * Indicates that this server is the live customer-facing production server.
  */
@@ -62,6 +31,6 @@ const demandInProduction = IS_PRODUCTION_SERVER
 
 export const GOOGLE_ANALYTICS_ID = demandInProduction("GOOGLE_ANALYTICS_ID");
 export const AMPLITUDE_API_KEY = demandInProduction("AMPLITUDE_API_KEY");
-export const WALLETCONNECT_PROJECT_ID = demandExceptGHA(
+export const WALLETCONNECT_PROJECT_ID = demandInProduction(
   "WALLETCONNECT_PROJECT_ID",
 );