fix: abis, interfaces

Author: tejasbadadare

target_chains/ethereum/contracts/contracts/pyth/Pyth.sol

@@ -208,10 +208,10 @@ abstract contract Pyth is
         if (k < context.priceIds.length && context.priceFeeds[k].id == 0) {
             uint publishTime = uint(priceInfo.publishTime);
             if (
-                publishTime >= context.config.minPublishTime &&
-                publishTime <= context.config.maxPublishTime &&
-                (!context.config.checkUniqueness ||
-                    context.config.minPublishTime > prevPublishTime)
+                publishTime >= context.minAllowedPublishTime &&
+                publishTime <= context.maxAllowedPublishTime &&
+                (!context.checkUniqueness ||
+                    context.minAllowedPublishTime > prevPublishTime)
             ) {
                 context.priceFeeds[k].id = priceId;
                 context.priceFeeds[k].price.price = priceInfo.price;
@@ -231,7 +231,7 @@ abstract contract Pyth is
     function _processSingleUpdateDataBlob(
         bytes calldata singleUpdateData,
         PythInternalStructs.UpdateParseContext memory context
-    ) internal view {
+    ) internal view returns (uint64 numUpdates) {
         // Check magic number and length first
         if (
             singleUpdateData.length <= 4 ||
@@ -281,12 +281,18 @@ abstract contract Pyth is
         if (offset != encoded.length) {
             revert PythErrors.InvalidUpdateData();
         }
+
+        // Return the number of updates in this blob for tracking
+        return merkleData.numUpdates;
     }
 
     function parsePriceFeedUpdatesInternal(
         bytes[] calldata updateData,
         bytes32[] calldata priceIds,
-        PythInternalStructs.ParseConfig memory config
+        uint64 minAllowedPublishTime,
+        uint64 maxAllowedPublishTime,
+        bool checkUniqueness,
+        bool checkUpdateDataIsMinimal
     )
         internal
         returns (
@@ -299,39 +305,38 @@ abstract contract Pyth is
             if (msg.value < requiredFee) revert PythErrors.InsufficientFee();
         }
 
-        // In minimal update data mode, revert if we have more or less updates than price IDs
-        if (config.checkUpdateDataIsMinimal) {
-            uint64 totalUpdatesAcrossBlobs = 0;
-            for (uint i = 0; i < updateData.length; i++) {
-                (uint offset, ) = extractUpdateTypeFromAccumulatorHeader(
-                    updateData[i]
-                );
-
-                totalUpdatesAcrossBlobs += parseWormholeMerkleHeaderNumUpdates(
-                    updateData[i],
-                    offset
-                );
-            }
-            if (totalUpdatesAcrossBlobs != priceIds.length) {
-                revert PythErrors.InvalidArgument();
-            }
-        }
-
         // Create the context struct that holds all shared parameters
         PythInternalStructs.UpdateParseContext memory context;
         context.priceIds = priceIds;
-        context.config = config;
+        context.minAllowedPublishTime = minAllowedPublishTime;
+        context.maxAllowedPublishTime = maxAllowedPublishTime;
+        context.checkUniqueness = checkUniqueness;
+        context.checkUpdateDataIsMinimal = checkUpdateDataIsMinimal;
         context.priceFeeds = new PythStructs.PriceFeed[](priceIds.length);
         context.slots = new uint64[](priceIds.length);
 
+        // Track total updates for minimal update data check
+        uint64 totalUpdatesAcrossBlobs = 0;
+
         unchecked {
             // Process each update, passing the context struct
             // Parsed results will be filled in context.priceFeeds and context.slots
             for (uint i = 0; i < updateData.length; i++) {
-                _processSingleUpdateDataBlob(updateData[i], context);
+                totalUpdatesAcrossBlobs += _processSingleUpdateDataBlob(
+                    updateData[i],
+                    context
+                );
             }
         }
 
+        // In minimal update data mode, revert if we have more or less updates than price IDs
+        if (
+            checkUpdateDataIsMinimal &&
+            totalUpdatesAcrossBlobs != priceIds.length
+        ) {
+            revert PythErrors.InvalidArgument();
+        }
+
         // Check all price feeds were found
         for (uint k = 0; k < priceIds.length; k++) {
             if (context.priceFeeds[k].id == 0) {
@@ -356,12 +361,10 @@ abstract contract Pyth is
         (priceFeeds, ) = parsePriceFeedUpdatesInternal(
             updateData,
             priceIds,
-            PythInternalStructs.ParseConfig(
-                minPublishTime,
-                maxPublishTime,
-                false,
-                false
-            )
+            minPublishTime,
+            maxPublishTime,
+            false,
+            false
         );
     }
 
@@ -383,12 +386,10 @@ abstract contract Pyth is
             parsePriceFeedUpdatesInternal(
                 updateData,
                 priceIds,
-                PythInternalStructs.ParseConfig(
-                    minPublishTime,
-                    maxPublishTime,
-                    false,
-                    true
-                )
+                minPublishTime,
+                maxPublishTime,
+                false,
+                true
             );
     }
 
@@ -567,12 +568,10 @@ abstract contract Pyth is
         (priceFeeds, ) = parsePriceFeedUpdatesInternal(
             updateData,
             priceIds,
-            PythInternalStructs.ParseConfig(
-                minPublishTime,
-                maxPublishTime,
-                true,
-                false
-            )
+            minPublishTime,
+            maxPublishTime,
+            true,
+            false
         );
     }
 

target_chains/ethereum/contracts/contracts/pyth/PythInternalStructs.sol

@@ -9,22 +9,18 @@ import "@pythnetwork/pyth-sdk-solidity/PythStructs.sol";
 contract PythInternalStructs {
     using BytesLib for bytes;
 
-    struct ParseConfig {
-        uint64 minPublishTime;
-        uint64 maxPublishTime;
-        bool checkUniqueness;
-        /// When checkUpdateDataIsMinimal is true, parsing will revert
-        /// if the number of passed in updates exceeds or is less than
-        /// the length of priceIds.
-        bool checkUpdateDataIsMinimal;
-    }
-
     /// Internal struct to hold parameters for update processing
     /// @dev Storing these variable in a struct rather than local variables
     /// helps reduce stack depth when passing arguments to functions.
     struct UpdateParseContext {
         bytes32[] priceIds;
-        ParseConfig config;
+        uint64 minAllowedPublishTime;
+        uint64 maxAllowedPublishTime;
+        bool checkUniqueness;
+        /// When checkUpdateDataIsMinimal is true, parsing will revert
+        /// if the number of passed in updates exceeds or is less than
+        /// the length of priceIds.
+        bool checkUpdateDataIsMinimal;
         PythStructs.PriceFeed[] priceFeeds;
         uint64[] slots;
     }

target_chains/ethereum/contracts/forge-test/PulseScheduler.t.sol

@@ -248,7 +248,11 @@ contract SchedulerTest is Test, SchedulerEvents, PulseSchedulerTestUtils {
             numInitialFeeds
         );
 
-        mockParsePriceFeedUpdatesWithSlotsStrict(pyth, initialPriceFeeds, slots);
+        mockParsePriceFeedUpdatesWithSlotsStrict(
+            pyth,
+            initialPriceFeeds,
+            slots
+        );
         bytes[] memory updateData = createMockUpdateData(initialPriceFeeds);
 
         vm.prank(pusher);
@@ -1855,7 +1859,7 @@ contract SchedulerTest is Test, SchedulerEvents, PulseSchedulerTestUtils {
         slots[1] = 100; // Same slot
 
         // Mock Pyth response (should succeed in the real world as minValidTime is 0)
-        mockParsePriceFeedUpdatesWithSlots(pyth, priceFeeds, slots);
+        mockParsePriceFeedUpdatesWithSlotsStrict(pyth, priceFeeds, slots);
         bytes[] memory updateData = createMockUpdateData(priceFeeds);
 
         // Expect PricesUpdated event with the latest valid timestamp
@@ -1908,7 +1912,7 @@ contract SchedulerTest is Test, SchedulerEvents, PulseSchedulerTestUtils {
         slots[1] = 100; // Same slot
 
         // Mock Pyth response (should succeed in the real world as minValidTime is 0)
-        mockParsePriceFeedUpdatesWithSlots(pyth, priceFeeds, slots);
+        mockParsePriceFeedUpdatesWithSlotsStrict(pyth, priceFeeds, slots);
         bytes[] memory updateData = createMockUpdateData(priceFeeds);
 
         // Expect revert with TimestampTooOld (checked in _validateShouldUpdatePrices)

target_chains/ethereum/sdk/solidity/MockPyth.sol

@@ -164,7 +164,7 @@ contract MockPyth is AbstractPyth {
         );
     }
 
-    function parsePriceFeedUpdatesWithSlots(
+    function parsePriceFeedUpdatesWithSlotsStrict(
         bytes[] calldata updateData,
         bytes32[] calldata priceIds,
         uint64 minPublishTime,

target_chains/ethereum/sdk/solidity/PythAggregatorV3.sol

@@ -31,7 +31,10 @@ contract PythAggregatorV3 {
         pyth.updatePriceFeeds{value: fee}(priceUpdateData);
 
         // refund remaining eth
-        payable(msg.sender).call{value: address(this).balance}("");
+        // solhint-disable-next-line no-unused-vars
+        (bool success, ) = payable(msg.sender).call{
+            value: address(this).balance
+        }("");
     }
 
     function decimals() public view virtual returns (uint8) {

target_chains/ethereum/sdk/solidity/abis/AbstractPyth.json

@@ -589,7 +589,7 @@
         "type": "uint64"
       }
     ],
-    "name": "parsePriceFeedUpdatesWithSlots",
+    "name": "parsePriceFeedUpdatesWithSlotsStrict",
     "outputs": [
       {
         "components": [

target_chains/ethereum/sdk/solidity/abis/IPyth.json

@@ -479,7 +479,7 @@
         "type": "uint64"
       }
     ],
-    "name": "parsePriceFeedUpdatesWithSlots",
+    "name": "parsePriceFeedUpdatesWithSlotsStrict",
     "outputs": [
       {
         "components": [

target_chains/ethereum/sdk/solidity/abis/MockPyth.json

@@ -728,7 +728,7 @@
         "type": "uint64"
       }
     ],
-    "name": "parsePriceFeedUpdatesWithSlots",
+    "name": "parsePriceFeedUpdatesWithSlotsStrict",
     "outputs": [
       {
         "components": [