chore(hermes): small improvements to add tests in CI and more (#1393)

* fix(hermes): fix a broken test

* refactor(hermes): add clippy to pre-commit

* feat(hermes): add ci for tests

* chore(hermes): remove legacy go footprint

* fix: add protoc action for ci

* chore: rebase on top of main

* fix: use right rust version for the Dockerfile

* fix: fix precommit ci

Author: ali-behjati

.github/workflows/ci-hermes.yml

@@ -0,0 +1,23 @@
+name: Check Hermes
+
+on:
+  pull_request:
+    paths: [hermes/**]
+  push:
+    branches: [main]
+    paths: [hermes/**]
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - uses: actions-rs/toolchain@v1
+        with:
+          profile: minimal
+          toolchain: nightly-2024-03-26
+          components: rustfmt, clippy
+          override: true
+      - name: Install protoc
+        uses: arduino/setup-protoc@v3
+      - name: Run executor tests
+        run: cargo test --manifest-path ./hermes/Cargo.toml

.github/workflows/ci-pre-commit.yml

@@ -27,6 +27,13 @@ jobs:
           profile: minimal
           toolchain: nightly-2023-07-23
           components: rustfmt, clippy
+      - uses: actions-rs/toolchain@v1
+        with:
+          profile: minimal
+          toolchain: nightly-2024-03-26
+          components: rustfmt, clippy
+      - name: Install protoc
+        uses: arduino/setup-protoc@v3
       - uses: actions/checkout@v4
       - name: Install poetry
         run: pipx install poetry

.pre-commit-config.yaml

@@ -30,21 +30,6 @@ repos:
         entry: cargo +nightly-2023-03-01 clippy --manifest-path ./governance/remote_executor/Cargo.toml --tests --fix --allow-dirty --allow-staged -- -D warnings
         pass_filenames: false
         files: governance/remote_executor
-      # Hooks for the attester
-      - id: cargo-fmt-attester
-        name: Cargo format for attester
-        language: "rust"
-        entry: cargo +nightly-2023-03-01 fmt --manifest-path ./wormhole_attester/Cargo.toml --all -- --config-path rustfmt.toml
-        pass_filenames: false
-        files: wormhole_attester
-      - id: cargo-clippy-attester
-        name: Cargo clippy for attester
-        language: "rust"
-        entry: |
-          bash -c 'EMITTER_ADDRESS=0 BRIDGE_ADDRESS=0 cargo +nightly-2023-03-01 clippy --manifest-path \
-            ./wormhole_attester/Cargo.toml --tests --fix --allow-dirty --allow-staged -- -D warnings'
-        pass_filenames: false
-        files: wormhole_attester
       # Hooks for cosmwasm contract
       - id: cargo-fmt-cosmwasm
         name: Cargo format for cosmwasm contract
@@ -60,9 +45,15 @@ repos:
         files: target_chains/cosmwasm
       # Hooks for Hermes
       - id: cargo-fmt-hermes
-        name: Cargo format for Pyth Hermes
+        name: Cargo format for Hermes
+        language: "rust"
+        entry: cargo +nightly-2024-03-26 fmt --manifest-path ./hermes/Cargo.toml --all -- --config-path rustfmt.toml
+        pass_filenames: false
+        files: hermes
+      - id: cargo-clippy-hermes
+        name: Cargo clippy for Hermes
         language: "rust"
-        entry: cargo +nightly-2023-07-23 fmt --manifest-path ./hermes/Cargo.toml --all -- --config-path rustfmt.toml
+        entry: cargo +nightly-2024-03-26 clippy --manifest-path ./hermes/Cargo.toml --tests --fix --allow-dirty --allow-staged -- -D warnings
         pass_filenames: false
         files: hermes
       # Hooks for Fortuna

hermes/Dockerfile

@@ -1,19 +1,14 @@
-FROM docker.io/golang:1.20.4@sha256:6dd5c5f8936d7d4487802fb10a77f31b1776740be0fc17ada1acb74ac958f7be AS build
+# The rust version itself is not so important as we install a fixed
+# nightly version. We use the latest stable version to get the latest
+# updates and dependencies.
+FROM rust:1.77.0 AS build
 
 # Install OS packages
 RUN apt-get update && apt-get install --yes \
     build-essential curl clang libssl-dev protobuf-compiler
 
-# Install Rust
-RUN curl https://sh.rustup.rs -sSf | sh -s -- -y --quiet --no-modify-path
-ENV PATH="/root/.cargo/bin:${PATH}"
-
-# Install Solana
-RUN sh -c "$(curl -sSfL https://release.solana.com/v1.14.17/install)"
-ENV PATH="/root/.local/share/solana/install/active_release/bin:$PATH"
-
 # Set default toolchain
-RUN rustup default nightly-2023-07-23
+RUN rustup default nightly-2024-03-26
 
 # Build
 WORKDIR /src
@@ -25,7 +20,7 @@ WORKDIR /src/hermes
 
 RUN --mount=type=cache,target=/root/.cargo/registry cargo build --release
 
-FROM docker.io/golang:1.20.4@sha256:6dd5c5f8936d7d4487802fb10a77f31b1776740be0fc17ada1acb74ac958f7be
+FROM rust:1.77.0
 
 # Copy artifacts from other images
 COPY --from=build /src/hermes/target/release/hermes /usr/local/bin/