Skip to content

Commit 966dfa4

Browse files
refactor: remove mention of gas config in sub param validation (#2641)
1 parent 85213c5 commit 966dfa4

File tree

1 file changed

+5
-9
lines changed

1 file changed

+5
-9
lines changed

target_chains/ethereum/contracts/contracts/pulse/Scheduler.sol

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,7 @@ abstract contract Scheduler is IScheduler, SchedulerState {
3030
function createSubscription(
3131
SubscriptionParams memory subscriptionParams
3232
) external payable override returns (uint256 subscriptionId) {
33-
// Validate params and set default gas config
34-
_validateAndPrepareSubscriptionParams(subscriptionParams);
33+
_validateSubscriptionParams(subscriptionParams);
3534

3635
// Calculate minimum balance required for this subscription
3736
uint256 minimumBalance = this.getMinimumBalance(
@@ -97,9 +96,7 @@ abstract contract Scheduler is IScheduler, SchedulerState {
9796
emit SubscriptionUpdated(subscriptionId);
9897
return;
9998
}
100-
101-
// Validate the new parameters, including setting default gas config
102-
_validateAndPrepareSubscriptionParams(newParams);
99+
_validateSubscriptionParams(newParams);
103100

104101
// Check minimum balance if number of feeds increases and subscription remains active
105102
if (
@@ -150,11 +147,10 @@ abstract contract Scheduler is IScheduler, SchedulerState {
150147
}
151148

152149
/**
153-
* @notice Validates subscription parameters and sets default gas config if needed.
154-
* @dev This function modifies the passed-in params struct in place for gas config defaults.
155-
* @param params The subscription parameters to validate and prepare.
150+
* @notice Validates subscription parameters.
151+
* @param params The subscription parameters to validate.
156152
*/
157-
function _validateAndPrepareSubscriptionParams(
153+
function _validateSubscriptionParams(
158154
SubscriptionParams memory params
159155
) internal pure {
160156
// No zero‐feed subscriptions

0 commit comments

Comments
 (0)