File tree Expand file tree Collapse file tree 2 files changed +0
-15
lines changed
target_chains/ethereum/contracts/contracts/pulse Expand file tree Collapse file tree 2 files changed +0
-15
lines changed Original file line number Diff line number Diff line change @@ -140,18 +140,6 @@ abstract contract Pulse is IPulse, PulseState {
140140
141141 clearRequest (sequenceNumber);
142142
143- // TODO: I'm pretty sure this is going to use a lot of gas because it's doing a storage lookup for each sequence number.
144- // a better solution would be a doubly-linked list of active requests.
145- // After successful callback, update firstUnfulfilledSeq if needed
146- /*
147- while (
148- _state.firstUnfulfilledSeq < _state.currentSequenceNumber &&
149- !isActive(findRequest(_state.firstUnfulfilledSeq))
150- ) {
151- _state.firstUnfulfilledSeq++;
152- }
153- */
154-
155143 try
156144 IPulseConsumer (req.requester)._pulseCallback {
157145 gas: req.callbackGasLimit
Original file line number Diff line number Diff line change @@ -5,9 +5,6 @@ pragma solidity ^0.8.0;
55contract PulseState {
66 uint8 public constant NUM_REQUESTS = 32 ;
77 bytes1 public constant NUM_REQUESTS_MASK = 0x1f ;
8- // Maximum number of price feeds per request. This limit keeps gas costs predictable and reasonable. 10 is a reasonable number for most use cases.
9- // Requests with more than 10 price feeds should be split into multiple requests
10- uint8 public constant MAX_PRICE_IDS = 2 ;
118
129 struct Request {
1310 address requester;
You can’t perform that action at this time.
0 commit comments