stash while checking build errors

Author: ayushboss

target_chains/ethereum/abi_generator/src/index.js

@@ -42,9 +42,29 @@ function generateAbi(contracts) {
     fs.mkdirSync("abis");
   }
 
+  if (output.errors) {
+    // We can still generate ABIs with warnings, only throw for errors
+    const errors = output.errors.filter((e) => e.severity === "error");
+    if (errors.length > 0) {
+      console.error("Compilation errors:");
+      for (const error of errors) {
+        console.error(error.formattedMessage || error.message);
+      }
+      throw new Error("Compilation failed due to errors");
+    }
+  }
+
+
   for (let contract of contracts) {
     const contractFile = `${contract}.sol`;
 
+    if (!output.contracts[contractFile]) {
+      throw new Error(`Unable to produce ABI for ${contractFile}.`);
+    }
+    if (!output.contracts[contractFile][contract]) {
+      throw new Error(`Unable to produce ABI for ${contractFile}:${contract}.`);
+    }
+
     const abi = output.contracts[contractFile][contract].abi;
     fs.writeFileSync(
       `abis/${contract}.json`,

target_chains/ethereum/sdk/solidity/IPyth.sol

@@ -143,8 +143,8 @@ interface IPyth is IPythEvents {
     /// no update for any of the given `priceIds` within the given time range.
     /// @param updateData Array of price update data.
     /// @param priceIds Array of price ids.
-    /// @param minPublishTime minimum acceptable publishTime for the given `priceIds`.
-    /// @param maxPublishTime maximum acceptable publishTime for the given `priceIds`.
+    /// @param minAllowedPublishTime minimum acceptable publishTime for the given `priceIds`.
+    /// @param maxAllowedPublishTime maximum acceptable publishTime for the given `priceIds`.
     /// @param storeUpdatesIfFresh flag for the parse function to 
     /// @return priceFeeds Array of the price feeds corresponding to the given `priceIds` (with the same order).
     function parsePriceFeedUpdatesWithConfig(
@@ -155,7 +155,7 @@ interface IPyth is IPythEvents {
         bool checkUniqueness,
         bool checkUpdateDataIsMinimal,
         bool storeUpdatesIfFresh
-    ) public returns ( PythStructs.PriceFeed[] memory priceFeeds, uint64[] memory slots);
+    ) external returns ( PythStructs.PriceFeed[] memory priceFeeds, uint64[] memory slots);
 
     /// @notice Parse time-weighted average price (TWAP) from two consecutive price updates for the given `priceIds`.
     ///

target_chains/ethereum/sdk/solidity/abis/IPyth.json

@@ -475,6 +475,121 @@
     "stateMutability": "payable",
     "type": "function"
   },
+  {
+    "inputs": [
+      {
+        "internalType": "bytes[]",
+        "name": "updateData",
+        "type": "bytes[]"
+      },
+      {
+        "internalType": "bytes32[]",
+        "name": "priceIds",
+        "type": "bytes32[]"
+      },
+      {
+        "internalType": "uint64",
+        "name": "minAllowedPublishTime",
+        "type": "uint64"
+      },
+      {
+        "internalType": "uint64",
+        "name": "maxAllowedPublishTime",
+        "type": "uint64"
+      },
+      {
+        "internalType": "bool",
+        "name": "checkUniqueness",
+        "type": "bool"
+      },
+      {
+        "internalType": "bool",
+        "name": "checkUpdateDataIsMinimal",
+        "type": "bool"
+      },
+      {
+        "internalType": "bool",
+        "name": "storeUpdatesIfFresh",
+        "type": "bool"
+      }
+    ],
+    "name": "parsePriceFeedUpdatesWithConfig",
+    "outputs": [
+      {
+        "components": [
+          {
+            "internalType": "bytes32",
+            "name": "id",
+            "type": "bytes32"
+          },
+          {
+            "components": [
+              {
+                "internalType": "int64",
+                "name": "price",
+                "type": "int64"
+              },
+              {
+                "internalType": "uint64",
+                "name": "conf",
+                "type": "uint64"
+              },
+              {
+                "internalType": "int32",
+                "name": "expo",
+                "type": "int32"
+              },
+              {
+                "internalType": "uint256",
+                "name": "publishTime",
+                "type": "uint256"
+              }
+            ],
+            "internalType": "struct PythStructs.Price",
+            "name": "price",
+            "type": "tuple"
+          },
+          {
+            "components": [
+              {
+                "internalType": "int64",
+                "name": "price",
+                "type": "int64"
+              },
+              {
+                "internalType": "uint64",
+                "name": "conf",
+                "type": "uint64"
+              },
+              {
+                "internalType": "int32",
+                "name": "expo",
+                "type": "int32"
+              },
+              {
+                "internalType": "uint256",
+                "name": "publishTime",
+                "type": "uint256"
+              }
+            ],
+            "internalType": "struct PythStructs.Price",
+            "name": "emaPrice",
+            "type": "tuple"
+          }
+        ],
+        "internalType": "struct PythStructs.PriceFeed[]",
+        "name": "priceFeeds",
+        "type": "tuple[]"
+      },
+      {
+        "internalType": "uint64[]",
+        "name": "slots",
+        "type": "uint64[]"
+      }
+    ],
+    "stateMutability": "nonpayable",
+    "type": "function"
+  },
   {
     "inputs": [
       {