[solana] A working solana receiver program (#632)

* A working version of solana receiver

* Cleanup

* Minor

* Commit for triggering tilt

* Add program key starting with pyth

* Remove duplicated hard-coded wormhole address

* Add check for VAA magic number and emmitter is Pythnet or Solana

* Cleaner command for building the cli package

* Fix bug and use BatchPriceAttestation for deserialization

* minor

Author: yhzhang0128

target_chains/solana/Anchor.toml

@@ -1,15 +1,18 @@
 [features]
 seeds = false
 skip-lint = false
-[programs.localnet]
-solana_receiver = "Fg6PaFpoGXkYsidMpWTK6W2BeZ7FEfcYkg476zPFsLnS"
+
+[programs.devnet]
+pyth_solana_receiver = "pythKkWXoywbvTQVcWrNDz5ENvWteF7tem7xzW52NBK"
 
 [registry]
 url = "https://api.apr.dev"
 
 [provider]
-cluster = "Localnet"
-wallet = "/home/yunhao/.config/solana/id.json"
+cluster = "https://api.devnet.solana.com"
+wallet = "~/.config/solana/id.json"
 
 [scripts]
-test = "yarn run ts-mocha -p ./tsconfig.json -t 1000000 tests/**/*.ts"
+deploy = "anchor deploy --program-keypair program_address.json --program-name solana-receiver"
+cli_build = "cargo build --package pyth-solana-receiver-cli"
+cli_test = "cargo run --package pyth-solana-receiver-cli post-and-receive-vaa -v AQAAAAABABPz9W9ARa/V06ZBp68lkoGJ3tlnJRZ2/jYU4Wi1jdQAdQj3ZkPLKIMtzN3EqaCAjKrLG/sKqADTbPoaBtn9zKUBZAYEhwAAAAAAAfNGGVrALzfWDU24/6bvdMsb41UAR1Q6Sp7prPTXhpewAAAAAApC0/gBUDJXSAADAAEAAQIAAwCdfVoraihHxJUfK+NKfkJ4r4DsPSm8uMcxEWv1D/av5l7/DsJkQsV9dFZpW4Q2lOc3mxXPGyULJ+DkfmV/GVWq/wAAAAAAG8iMAAAAAAAAARb////7AAAAAAAbz04AAAAAAAABfQEAAAACAAAACwAAAABkBgSHAAAAAGQGBIcAAAAAZAYEhwAAAAAAG8hzAAAAAAAAAS8AAAAAZAYEhD3tPwvP5dgslVQroHu37+dlyxeoTqcDWIDDMUz5Y0KBMhuk1gj6dbp21tc9qnFavL3rnboCJX8FobWReLSfWZsAAAAAACBQdgAAAAAAAANS////+wAAAAAAID+JAAAAAAAAA00BAAAAAgAAAAsAAAAAZAYEhwAAAABkBgSHAAAAAGQGBIYAAAAAACBQKwAAAAAAAAOdAAAAAGQGBIRPu3srgFy1FVEoeBBWS6f74PhYsJvdbggVRmGyUzFy1DChkVj1pUwK34+3VgYnND8iobyFK4nVa+GszcXb+W0OAAAAAAAcQ44AAAAAAAAAhP////0AAAAAABxBSQAAAAAAAACXAQAAAAIAAAATAAAAAGQGBIcAAAAAZAYEhwAAAABkBgSGAAAAAAAcQ28AAAAAAAAAZgAAAABkBgSE"

target_chains/solana/Cargo.lock

@@ -1,5 +1,31 @@
-# pythnet-solana-receiver
+# Solana program for receiving price VAA from Pythnet
 
-To compile the cli, run `make ccli`.
+The program under `cli` receives a VAA string from the shell, verifies the VAA with wormhole, posts the VAA on solana and then invokes the receiver program under `programs`.
+The receiver program verifies that the VAA comes from wormhole (through the `owner` function in `state.rs`) and deserializes the price information (in `decode_posted_vaa` function of `lib.rs`).
 
-To test post_vaa of the cli, run `make post_vaa`.
+```shell
+# Generate the program key
+# and use the key to replace the following two places
+#     "pyth_solana_receiver" in Anchor.toml
+#     "declare_id!()" in programs/solana-receiver/src/lib.rs
+> solana-keygen new -o program_address.json
+
+# Build and deploy the receiver program
+> anchor build
+> anchor run deploy
+
+# Build and test the cli program
+> anchor run cli_build
+> anchor run cli_test
+# Example output
+...
+[1/5] Decode the VAA
+[2/5] Get wormhole guardian set configuration
+[3/5] Invoke wormhole on solana to verify the VAA
+Transaction successful : 3VbrqQBCf1RsNLxrcvxN3aTb5fZRht4n8XDUVPM8NKniRmo84NZQUu5iFw5groAQgQYox3YCqaMjKc2WTpPU1yqV
+[4/5] Post the VAA data onto a solana account
+Transaction successful : 3L1vxzSHQv6B6TwtoMv2Y6m7vFGz3hzqApGHEhHSLA9Jn5dNKeWRWKv29UDPDc3vsgt1mYueamUPPt6bHGGEkbxh
+[5/5] Receive and deserialize the VAA on solana
+Receiver program ID is 5dXnHcDXdXaiEp9QgknCDPsEhJStSqZqJ4ATirWfEqeY
+Transaction successful : u5y9Hqc18so3BnjSUvZkLZR4mvA8zkiBgzGKHSEYyWkHQhH3uQatM7xWf4kdrhjZFVGbfBLdR8RJJUmuf28ePtG
+```

target_chains/solana/Makefile

@@ -11,5 +11,6 @@ solana-sdk = "1.10.31"
 solana-client = "1.10.31"
 anchor-client = "0.26.0"
 clap = {version ="3.2.22", features = ["derive"]}
+pyth-solana-receiver = {path = "../programs/solana-receiver"}
 wormhole-core = { git = "https://github.com/guibescos/wormhole", branch = "reisen/sdk-solana"}
 wormhole-solana = { git = "https://github.com/guibescos/wormhole", branch = "reisen/sdk-solana"}

target_chains/solana/README.md

@@ -1,4 +1,3 @@
-//! CLI options
 use {
     clap::{
         Parser,
@@ -18,26 +17,17 @@ pub struct Cli {
 
 #[derive(Subcommand, Debug)]
 pub enum Action {
-    #[clap(about = "Verify and post the price VAA on solana")]
-    PostPriceVAA {
+    #[clap(about = "Verify, post and receive the price VAA on solana")]
+    PostAndReceiveVAA {
         #[clap(short = 'v', long,
                help = "Price VAA from Pythnet")]
         vaa:     String,
         #[clap(
             short = 'k', long,
             default_value = "~/.config/solana/id.json",
-            help = "Keypair of the transaction's funder"
+            help = "Keypair of the payer of transactions"
         )]
         keypair: String,
     },
 
-    #[clap(about = "Invoke the on-chain contract decoding the VAA")]
-    InvokePriceReceiver {
-        #[clap(
-            short = 'k', long,
-            default_value = "~/.config/solana/id.json",
-            help = "Keypair of the transaction's funder"
-        )]
-        keypair: String,
-    },
 }

target_chains/solana/cli/Cargo.toml

@@ -7,10 +7,8 @@ use {
     },
     clap::Parser,
     anyhow::Result,
-    std::str::FromStr,
 
     solana_sdk::{
-        pubkey::Pubkey,
         signature::{
             read_keypair_file,
             Keypair,
@@ -22,36 +20,47 @@ use {
 
     wormhole::VAA,
     wormhole_solana::{
-        Account,
-        GuardianSet,
-        Config as WormholeConfig,
         instructions::{
             post_vaa,
             verify_signatures_txs,
             PostVAAData,
         },
+        Account,
+        GuardianSet,
+        Config as WormholeConfig,
+        VAA as WormholeSolanaVAA,
+    },
+
+    pyth_solana_receiver::{
+        ID,
+        state::AnchorVaa,
+        accounts::DecodePostedVaa,
+    },
+
+    anchor_client::anchor_lang::{
+        Owner,
+        ToAccountMetas,
+        InstructionData,
+        AnchorDeserialize,
     },
 
     solana_client::rpc_client::RpcClient,
-    anchor_client::anchor_lang::AnchorDeserialize,
 };
 
 fn main() -> Result<()> {
     let cli = Cli::parse();
 
     match cli.action {
-        Action::PostPriceVAA { vaa, keypair } => {
-            println!("PostPriceVAA is invoked with vaa\"{}\"", vaa);
-            // Hard-coded strings
+        Action::PostAndReceiveVAA { vaa, keypair } => {
+            let wormhole = AnchorVaa::owner();
             let rpc_client = RpcClient::new("https://api.devnet.solana.com");
-            // Is RpcClient::new_with_commitment necessary?
-            let wormhole = Pubkey::from_str("3u8hJUVTA4jH1wYAyUur7FFZVQ8H635K3tSHHF4ssjQ5").unwrap();
 
-            println!("Decode the VAA");
+            println!("[1/5] Decode the VAA");
             let vaa_bytes: Vec<u8> = base64::decode(vaa)?;
             let vaa = VAA::from_bytes(vaa_bytes.clone())?;
+            let posted_vaa_key = WormholeSolanaVAA::key(&wormhole, vaa.digest().unwrap().hash);
 
-            println!("Get wormhole guardian set configuration");
+            println!("[2/5] Get wormhole guardian set configuration");
             let wormhole_config = WormholeConfig::key(&wormhole, ());
             let wormhole_config_data =
                 WormholeConfig::try_from_slice(&rpc_client.get_account_data(&wormhole_config)?)?;
@@ -60,7 +69,7 @@ fn main() -> Result<()> {
             let guardian_set_data =
                 GuardianSet::try_from_slice(&rpc_client.get_account_data(&guardian_set)?)?;
 
-            println!("Invoke wormhole on solana to verify the VAA");
+            println!("[3/5] Invoke wormhole on solana to verify the VAA");
             let payer =
                 read_keypair_file(&*shellexpand::tilde(&keypair)).expect("Keypair not found");
             let signature_set_keypair = Keypair::new();
@@ -77,7 +86,7 @@ fn main() -> Result<()> {
                 process_transaction(&rpc_client, tx, &vec![&payer, &signature_set_keypair])?;
             }
 
-            println!("Upload the VAA data to a solana account");
+            println!("[4/5] Post the VAA data onto a solana account");
             let post_vaa_data = PostVAAData {
                 version:            vaa.version,
                 guardian_set_index: vaa.guardian_set_index,
@@ -100,10 +109,23 @@ fn main() -> Result<()> {
                 )?],
                 &vec![&payer],
             )?;
-        }
 
-        Action::InvokePriceReceiver { keypair } => {
-            println!("TBD, keypair={}", keypair);
+            println!("[5/5] Receive and deserialize the VAA on solana");
+            let account_metas = DecodePostedVaa::populate(&payer.pubkey(), &posted_vaa_key)
+                .to_account_metas(None);
+
+            println!("Receiver program ID is {}", ID);
+            let invoke_receiver_instruction = Instruction {
+                program_id: ID,
+                accounts:   account_metas,
+                data:       pyth_solana_receiver::instruction::DecodePostedVaa.data(),
+            };
+
+            process_transaction(
+                &rpc_client,
+                vec![invoke_receiver_instruction],
+                &vec![&payer],
+            )?;
         }
     }
 
@@ -118,8 +140,10 @@ pub fn process_transaction(
     let mut transaction =
         Transaction::new_with_payer(instructions.as_slice(), Some(&signers[0].pubkey()));
     transaction.sign(signers, rpc_client.get_latest_blockhash()?);
+
     let transaction_signature =
         rpc_client.send_and_confirm_transaction_with_spinner(&transaction)?;
     println!("Transaction successful : {transaction_signature:?}");
+
     Ok(())
 }

target_chains/solana/cli/src/cli.rs

@@ -0,0 +1,6 @@
+[
+  60, 149, 65, 82, 222, 44, 5, 183, 190, 133, 174, 157, 116, 169, 223, 187, 176,
+  116, 180, 249, 122, 201, 107, 232, 238, 112, 238, 241, 8, 143, 97, 41, 12, 74,
+  160, 14, 126, 203, 129, 160, 107, 74, 220, 154, 139, 58, 58, 125, 87, 41, 190,
+  231, 142, 176, 98, 77, 107, 78, 193, 20, 114, 34, 71, 146
+]