Skip to content

Commit c3e373e

Browse files
committed
chore: remove error expectations that no longer apply
There were a few @ts-expect-error and eslint-disable lines caused by typings which have been now fixed in the underlying libraries and so we can now remove those annotatinos.
1 parent e9cb367 commit c3e373e

File tree

5 files changed

+0
-20
lines changed

5 files changed

+0
-20
lines changed

apps/staking/src/components/ErrorMessage/index.tsx

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,6 @@ const UnknownError = ({ error }: { error: unknown }) => {
4949
</div>
5050
</Button>
5151
<m.div
52-
// @ts-expect-error the framer-motion types don't currently expose props
53-
// like `className` correctly for some reason, even though this works
54-
// correctly...
5552
className="overflow-hidden pt-1 opacity-60"
5653
initial={{ height: 0 }}
5754
animate={{ height: detailsOpen ? "auto" : 0 }}

apps/staking/src/components/Faq/index.tsx

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,9 +56,6 @@ export const Faq = ({ title, questions, className, ...props }: Props) => {
5656
</Button>
5757
</dt>
5858
<m.dt
59-
// @ts-expect-error the framer-motion types don't currently
60-
// expose props like `className` correctly for some reason, even
61-
// though this works correctly...
6259
className="-mt-1 flex max-w-prose flex-col gap-4 overflow-hidden font-light"
6360
initial={{ height: openItem === i ? "auto" : 0 }}
6461
animate={{ height: openItem === i ? "auto" : 0 }}

packages/component-library/src/Breadcrumbs/index.tsx

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -41,11 +41,6 @@ export const Breadcrumbs = ({ label, className, items, ...props }: Props) => (
4141
<Button
4242
size="xs"
4343
variant="outline"
44-
// I'm not quite sure why this is triggering, I'll need to
45-
// figure this out later. Something in Phosphor's types is
46-
// incorrect and is making eslint think this icon is an error
47-
// object somehow...
48-
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
4944
beforeIcon={House}
5045
hideText
5146
href="/"

packages/component-library/src/Drawer/index.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,6 @@ export const Drawer = ({
124124
if (e.type !== "pointercancel" && velocity.y > 10) {
125125
state.close();
126126
} else {
127-
// eslint-disable-next-line @typescript-eslint/no-floating-promises
128127
animate(y, "0", {
129128
type: "inertia",
130129
bounceStiffness: 300,

packages/component-library/src/Paginator/index.tsx

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -107,10 +107,6 @@ const PaginatorToolbar = ({
107107
<Toolbar aria-label="Page" className={styles.paginatorToolbar ?? ""}>
108108
<PageSelector
109109
hideText
110-
// I'm not quite sure why this is triggering, I'll need to figure this
111-
// out later. Something in Phosphor's types is incorrect and is making
112-
// eslint think this icon is an error object somehow...
113-
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
114110
beforeIcon={CaretLeft}
115111
isDisabled={currentPage === 1}
116112
page={1}
@@ -136,10 +132,6 @@ const PaginatorToolbar = ({
136132
})}
137133
<PageSelector
138134
hideText
139-
// I'm not quite sure why this is triggering, I'll need to figure this
140-
// out later. Something in Phosphor's types is incorrect and is making
141-
// eslint think this icon is an error object somehow...
142-
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
143135
beforeIcon={CaretRight}
144136
isDisabled={currentPage === numPages}
145137
page={numPages}

0 commit comments

Comments
 (0)