Add set fee to tests + add some sanity checks (#350)

* Add set fee to tests + add some sanity checks

* Add fee to evm relayer

Author: ali-behjati

ethereum/migrations/prod/12_pyth_set_fee_1_wei.js

@@ -1,3 +1,8 @@
+const { assert } = require("chai");
+const governance = require("@pythnetwork/xc-governance-sdk");
+const assertVaaPayloadEquals = require("../../scripts/assertVaaPayloadEquals");
+const { assert } = require("chai");
+
 const loadEnv = require("../../scripts/loadEnv");
 loadEnv("../../");
 
@@ -13,5 +18,18 @@ const PythUpgradable = artifacts.require("PythUpgradable");
  */
 module.exports = async function (_deployer) {
     const proxy = await PythUpgradable.deployed();
+
+    const setFeeInstruction = new governance.SetFeeInstruction(
+        governance.CHAINS.unset, // All the chains
+        BigInt(1),
+        BigInt(0),
+    ).serialize();
+
+    console.log("SetFeeInstruction: 0x", setFeeInstruction.toString('hex'));
+
+    assertVaaPayloadEquals(setFeeVaa, setFeeInstruction);
+
     await proxy.executeGovernanceInstruction(setFeeVaa);
+
+    assert.equal((await proxy.singleUpdateFeeInWei()).toString(), "1");
 }

ethereum/migrations/test/12_pyth_set_fee_1_wei.js

@@ -0,0 +1,37 @@
+const createLocalnetGovernanceVaa = require("../../scripts/createLocalnetGovernanceVaa");
+const assertVaaPayloadEquals = require("../../scripts/assertVaaPayloadEquals");
+const governance = require("@pythnetwork/xc-governance-sdk");
+const { assert } = require("chai");
+
+const loadEnv = require("../../scripts/loadEnv");
+loadEnv("../../");
+
+
+const PythUpgradable = artifacts.require("PythUpgradable");
+
+/**
+ * 
+ * This change:
+ * - Executes the VAA to set the fee to 1 wei
+ */
+module.exports = async function (_deployer) {
+    const setFeeInstruction = new governance.SetFeeInstruction(
+        governance.CHAINS.unset, // All the chains
+        BigInt(1),
+        BigInt(0),
+    ).serialize();
+
+    console.log("SetFeeInstruction: 0x", setFeeInstruction.toString('hex'));
+
+    const setFeeVaa = createLocalnetGovernanceVaa(
+        setFeeInstruction,
+        2
+    );
+
+    assertVaaPayloadEquals(setFeeVaa, setFeeInstruction);
+
+    const proxy = await PythUpgradable.deployed();
+    await proxy.executeGovernanceInstruction(setFeeVaa);
+
+    assert.equal((await proxy.singleUpdateFeeInWei()).toString(), "1");
+}

ethereum/package-lock.json

@@ -27,6 +27,7 @@
   "author": "",
   "license": "ISC",
   "dependencies": {
+    "@certusone/wormhole-sdk-wasm": "^0.0.1",
     "@openzeppelin/contracts": "^4.5.0",
     "@openzeppelin/contracts-upgradeable": "^4.5.2",
     "@pythnetwork/pyth-sdk-solidity": "^1.0.1",

ethereum/package.json

@@ -0,0 +1,16 @@
+
+const { importCoreWasm, setDefaultWasm } = require("@certusone/wormhole-sdk-wasm");
+setDefaultWasm("node");
+const { assert } = require("chai");
+
+module.exports = async function assertVaaPayloadEquals(vaaHexString, expectedPayloadBuffer) {
+  const { parse_vaa } = await importCoreWasm();
+
+  if (vaaHexString.startsWith("0x")) {
+    vaaHexString = vaaHexString.substring(2);
+  }
+
+  const vaaPayload = Buffer.from(parse_vaa(Buffer.from(vaaHexString, 'hex')).payload);
+
+  assert(expectedPayloadBuffer.equals(vaaPayload), "The VAA payload is not equal to the expected payload");
+}

ethereum/scripts/assertVaaPayloadEquals.js

@@ -45,8 +45,10 @@ export class EvmRelay implements Relay {
         ? await this.queryMany(priceIds)
         : null;
 
+      const updateFee = await this.p2wContract.getUpdateFee(1);
+
       let tx = this.p2wContract
-        .updatePriceFeeds(["0x" + signedVAAs[i]], { gasLimit: 2000000 })
+        .updatePriceFeeds(["0x" + signedVAAs[i]], { gasLimit: 2000000, value: updateFee })
         .then(async (pending) => {
           let receipt = await pending.wait();
           logger.info(