[sui 6/x] - Pyth unit tests (#757)

* state getters and setters, change Move.toml dependency to sui/integration_v2

* finish state.move

* add new line to pyth

* use deployer cap pattern for state module

* sui pyth

* update price feeds, dynamic object fields, Sui object PriceInfoObject

* register price info object with pyth state after creation

* sui governance

* some newlines

* error codes

* update and comment

* unit tests for pyth.move, add UpgradeCap to Pyth State (will be used for contract upgrades)

* updates

* test_get_update_fee test passes

* fix test_get_update_fee and test_update_price_feeds_corrupt_vaa

* test_update_price_feeds_invalid_data_source

* test_create_and_update_price_feeds

* test_create_and_update_price_feeds_success and test_create_and_update_price_feeds_price_info_object_not_found_failure

* test_update_cache

* update

* test_update_cache_old_update

* update_price_feeds_if_fresh

* comment

Author: optke3

target_chains/sui/contracts/Move.lock

@@ -0,0 +1,29 @@
+# @generated by Move, please check-in and do not edit manually.
+
+[move]
+version = 0
+
+dependencies = [
+  { name = "Sui" },
+  { name = "Wormhole" },
+]
+
+[[move.package]]
+name = "MoveStdlib"
+source = { git = "https://github.com/MystenLabs/sui.git", rev = "81dbcf2b6cab07d623a1012bf31daf658963c765", subdir = "crates/sui-framework/packages/move-stdlib" }
+
+[[move.package]]
+name = "Sui"
+source = { git = "https://github.com/MystenLabs/sui.git", rev = "81dbcf2b6cab07d623a1012bf31daf658963c765", subdir = "crates/sui-framework/packages/sui-framework" }
+
+dependencies = [
+  { name = "MoveStdlib" },
+]
+
+[[move.package]]
+name = "Wormhole"
+source = { git = "https://github.com/wormhole-foundation/wormhole.git", rev = "sui/integration_v2", subdir = "sui/wormhole" }
+
+dependencies = [
+  { name = "Sui" },
+]

target_chains/sui/contracts/Move.toml

@@ -5,7 +5,7 @@ version = "0.0.1"
 [dependencies.Sui]
 git = "https://github.com/MystenLabs/sui.git"
 subdir = "crates/sui-framework/packages/sui-framework"
-rev = "82c9c80c11488858f1d3930f47ec9f335a566683"
+rev = "ddfc3fa0768a38286787319603a5458a9ff91cc1"
 
 [dependencies.Wormhole]
 git = "https://github.com/wormhole-foundation/wormhole.git"

target_chains/sui/contracts/sources/governance/governance.move

@@ -1,5 +1,5 @@
 module pyth::governance {
-    use sui::tx_context::{TxContext};
+    use sui::clock::{Clock};
 
     use pyth::data_source::{Self};
     use pyth::governance_instruction;
@@ -19,14 +19,14 @@ module pyth::governance {
     const E_INVALID_GOVERNANCE_ACTION: u64 = 1;
     const E_INVALID_GOVERNANCE_DATA_SOURCE: u64 = 2;
     const E_INVALID_GOVERNANCE_SEQUENCE_NUMBER: u64 = 3;
-    
+
     public entry fun execute_governance_instruction(
         pyth_state : &mut State,
         worm_state: &WormState,
         vaa_bytes: vector<u8>,
-        ctx: &mut TxContext
+        clock: &Clock
     ) {
-        let parsed_vaa = parse_and_verify_governance_vaa(pyth_state, worm_state, vaa_bytes, ctx);
+        let parsed_vaa = parse_and_verify_governance_vaa(pyth_state, worm_state, vaa_bytes, clock);
         let instruction = governance_instruction::from_byte_vec(vaa::take_payload(parsed_vaa));
 
         // Dispatch the instruction to the appropiate handler
@@ -53,9 +53,9 @@ module pyth::governance {
         pyth_state: &mut State,
         worm_state: &WormState,
         bytes: vector<u8>,
-        ctx: &mut TxContext
+        clock: &Clock,
     ): VAA {
-        let parsed_vaa = vaa::parse_and_verify(worm_state, bytes, ctx);
+        let parsed_vaa = vaa::parse_and_verify(worm_state, bytes, clock);
 
         // Check that the governance data source is valid
         assert!(

target_chains/sui/contracts/sources/governance/governance_action.move

@@ -6,6 +6,7 @@ module pyth::governance_action {
     const SET_DATA_SOURCES: u8 = 2;
     const SET_UPDATE_FEE: u8 = 3;
     const SET_STALE_PRICE_THRESHOLD: u8 = 4;
+
     const E_INVALID_GOVERNANCE_ACTION: u64 = 5;
 
     struct GovernanceAction has copy, drop {

target_chains/sui/contracts/sources/governance/governance_instruction.move

@@ -9,7 +9,7 @@ module pyth::governance_instruction {
     const E_INVALID_GOVERNANCE_MODULE: u64 = 0;
     const E_INVALID_GOVERNANCE_MAGIC_VALUE: u64 = 1;
     const E_TARGET_CHAIN_MISMATCH: u64 = 2;
-    
+
     struct GovernanceInstruction {
         module_: u8,
         action: GovernanceAction,

target_chains/sui/contracts/sources/governance/set_data_sources.move

@@ -3,6 +3,7 @@ module pyth::set_data_sources {
 
     use wormhole::cursor;
     use wormhole::external_address::{Self};
+    use wormhole::bytes32::{Self};
 
     use pyth::deserialize;
     use pyth::data_source::{Self, DataSource};
@@ -28,7 +29,7 @@ module pyth::set_data_sources {
         let i = 0;
         while (i < data_sources_count) {
             let emitter_chain_id = deserialize::deserialize_u16(&mut cursor);
-            let emitter_address = external_address::from_bytes(deserialize::deserialize_vector(&mut cursor, 32));
+            let emitter_address = external_address::new(bytes32::from_bytes(deserialize::deserialize_vector(&mut cursor, 32)));
             vector::push_back(&mut sources, data_source::new((emitter_chain_id as u64), emitter_address));
 
             i = i + 1;

target_chains/sui/contracts/sources/governance/set_governance_data_source.move

@@ -5,6 +5,7 @@ module pyth::set_governance_data_source {
 
     use wormhole::cursor;
     use wormhole::external_address::{Self, ExternalAddress};
+    use wormhole::bytes32::{Self};
     //use wormhole::state::{Self}
 
     friend pyth::governance;
@@ -24,7 +25,7 @@ module pyth::set_governance_data_source {
     fun from_byte_vec(bytes: vector<u8>): SetGovernanceDataSource {
         let cursor = cursor::new(bytes);
         let emitter_chain_id = deserialize::deserialize_u16(&mut cursor);
-        let emitter_address = external_address::from_bytes(deserialize::deserialize_vector(&mut cursor, 32));
+        let emitter_address = external_address::new(bytes32::from_bytes(deserialize::deserialize_vector(&mut cursor, 32)));
         let initial_sequence = deserialize::deserialize_u64(&mut cursor);
         cursor::destroy_empty(cursor);
         SetGovernanceDataSource {

target_chains/sui/contracts/sources/price_info.move

@@ -13,8 +13,8 @@ module pyth::price_info {
 
     friend pyth::pyth;
 
-    /// Sui Object version of PriceInfo.
-    /// Has a key and lives in global store.
+    /// Sui object version of PriceInfo.
+    /// Has a key ability, is unique for each price identifier, and lives in global store.
     struct PriceInfoObject has key, store {
         id: UID,
         price_info: PriceInfo