cleanup

Author: jayantk

target_chains/ethereum/contracts/contracts/pulse/IPulse.sol

@@ -139,23 +139,4 @@ interface IPulse is PulseEvents {
     function setExclusivityPeriod(uint256 periodSeconds) external;
 
     function getExclusivityPeriod() external view returns (uint256);
-
-    /**
-     * @notice Gets the first N active requests
-     * @param count Maximum number of active requests to return
-     * @return requests Array of active requests, ordered from oldest to newest
-     * @return actualCount Number of active requests found (may be less than count)
-     * @dev Gas Usage: This function's gas cost scales linearly with the number of requests
-     *      between firstUnfulfilledSeq and currentSequenceNumber. Each iteration costs approximately:
-     *      - 2100 gas for cold storage reads, 100 gas for warm storage reads (SLOAD)
-     *      - Additional gas for array operations
-     *      The function starts from firstUnfulfilledSeq (all requests before this are fulfilled)
-     *      and scans forward until it finds enough active requests or reaches currentSequenceNumber.
-     */
-    function getFirstActiveRequests(
-        uint256 count
-    )
-        external
-        view
-        returns (PulseState.Request[] memory requests, uint256 actualCount);
 }

target_chains/ethereum/contracts/contracts/pulse/Pulse.sol

@@ -429,39 +429,4 @@ abstract contract Pulse is IPulse, PulseState {
     function getExclusivityPeriod() external view override returns (uint256) {
         return _state.exclusivityPeriodSeconds;
     }
-
-    function getFirstActiveRequests(
-        uint256 count
-    )
-        external
-        view
-        override
-        returns (Request[] memory requests, uint256 actualCount)
-    {
-        requests = new Request[](count);
-        actualCount = 0;
-
-        // Start from the first unfulfilled sequence and work forwards
-        // uint64 currentSeq = _state.firstUnfulfilledSeq;
-        uint64 currentSeq = 0;
-
-        // Continue until we find enough active requests or reach current sequence
-        while (
-            actualCount < count && currentSeq < _state.currentSequenceNumber
-        ) {
-            Request memory req = findRequest(currentSeq);
-            if (isActive(req)) {
-                requests[actualCount] = req;
-                actualCount++;
-            }
-            currentSeq++;
-        }
-
-        // If we found fewer requests than asked for, resize the array
-        if (actualCount < count) {
-            assembly {
-                mstore(requests, actualCount)
-            }
-        }
-    }
 }

target_chains/ethereum/contracts/contracts/pulse/PulseState.sol

@@ -7,11 +7,17 @@ contract PulseState {
     bytes1 public constant NUM_REQUESTS_MASK = 0x1f;
 
     struct Request {
+        // Storage word 1
         address requester;
         uint64 sequenceNumber;
+        // 4 bytes unused
+        // Storage word 2
         address provider;
         uint64 publishTime;
+        // 4 bytes unused
+        // Storage word 3
         bytes32 priceIdsHash;
+        // Storage word 4
         uint128 callbackGasLimit;
         uint128 fee;
     }
@@ -26,13 +32,21 @@ contract PulseState {
     }
 
     struct State {
+        // Storage word 1
         uint128 pythFeeInWei;
         uint128 accruedFeesInWei;
+        // Storage word 2
         address pyth;
         uint64 currentSequenceNumber;
+        // 4 bytes unused
+        // Storage word 3
         address defaultProvider;
+        // 12 bytes unused
+        // Storage word 4
         uint256 exclusivityPeriodSeconds;
+        // Storage word 5
         address admin;
+        // 12 bytes unused
         Request[NUM_REQUESTS] requests;
         mapping(bytes32 => Request) requestsOverflow;
         mapping(address => ProviderInfo) providers;