Skip to content

Commit ec6d0ce

Browse files
authored
Merge pull request #3094 from pyth-network/refactor/default-pages
refactor(component-library): set default page sizes
2 parents 17b86cc + 289a470 commit ec6d0ce

File tree

4 files changed

+4
-5
lines changed

4 files changed

+4
-5
lines changed

apps/insights/src/components/PriceComponentsCard/index.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -448,7 +448,6 @@ export const PriceComponentsCardContents = <
448448
onPageChange={props.onPageChange}
449449
pageSize={props.pageSize}
450450
onPageSizeChange={props.onPageSizeChange}
451-
pageSizeOptions={[10, 20, 30, 40, 50]}
452451
mkPageLink={props.mkPageLink}
453452
/>
454453
),

apps/insights/src/components/PriceFeeds/price-feeds-card.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -288,7 +288,6 @@ const PriceFeedsCardContents = ({ id, ...props }: PriceFeedsCardContents) => (
288288
onPageChange={props.onPageChange}
289289
pageSize={props.pageSize}
290290
onPageSizeChange={props.onPageSizeChange}
291-
pageSizeOptions={[10, 20, 30, 40, 50]}
292291
mkPageLink={props.mkPageLink}
293292
/>
294293
),

apps/insights/src/components/Publishers/publishers-card.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -290,7 +290,6 @@ const PublishersCardContents = ({
290290
onPageChange={props.onPageChange}
291291
pageSize={props.pageSize}
292292
onPageSizeChange={props.onPageSizeChange}
293-
pageSizeOptions={[10, 20, 30, 40, 50]}
294293
mkPageLink={props.mkPageLink}
295294
/>
296295
),

packages/component-library/src/Paginator/index.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,19 +19,21 @@ type Props = {
1919
onPageChange: (newPage: number) => void;
2020
isPageTransitioning?: boolean | undefined;
2121
pageSize: number;
22-
pageSizeOptions: number[];
22+
pageSizeOptions?: number[];
2323
onPageSizeChange: (newPageSize: number) => void;
2424
isPageSizeTransitioning?: boolean | undefined;
2525
mkPageLink?: ((page: number) => string) | undefined;
2626
className?: string | undefined;
2727
};
2828

29+
const DEFAULT_PAGE_SIZE_OPTIONS = [10, 20, 30, 40, 50];
30+
2931
export const Paginator = ({
3032
numPages,
3133
currentPage,
3234
isPageTransitioning,
3335
pageSize,
34-
pageSizeOptions,
36+
pageSizeOptions = DEFAULT_PAGE_SIZE_OPTIONS,
3537
onPageChange,
3638
onPageSizeChange,
3739
isPageSizeTransitioning,

0 commit comments

Comments
 (0)