fixed store = false test

Author: ayushboss

target_chains/ethereum/contracts/contracts/pyth/Pyth.sol

@@ -359,9 +359,24 @@ abstract contract Pyth is
                     updateData[i],
                     context
                 );
-                if (storeUpdatesIfFresh) {
-                    bytes32 curPriceId = context.priceIds[i];
-                    updateLatestPriceIfNecessary(curPriceId, _state.latestPriceInfo[curPriceId]);
+            }
+            
+            if (storeUpdatesIfFresh) {
+                for (uint j = 0; j < priceIds.length; j++) {
+                    bytes32 curPriceId = priceIds[j];
+                    if (context.priceFeeds[j].id != 0) {
+                        // Create a new PriceInfo memory object from the context.priceFeeds data
+                        PythInternalStructs.PriceInfo memory newInfo;
+                        newInfo.publishTime = uint64(context.priceFeeds[j].price.publishTime);
+                        newInfo.expo = context.priceFeeds[j].price.expo;
+                        newInfo.price = context.priceFeeds[j].price.price;
+                        newInfo.conf = context.priceFeeds[j].price.conf;
+                        newInfo.emaPrice = context.priceFeeds[j].emaPrice.price;
+                        newInfo.emaConf = context.priceFeeds[j].emaPrice.conf;
+                        
+                        // Pass the new memory object to update storage
+                        updateLatestPriceIfNecessary(curPriceId, newInfo);
+                    }
                 }
             }
         }

target_chains/ethereum/contracts/forge-test/Pyth.t.sol

@@ -335,26 +335,14 @@ contract PythTest is Test, WormholeTestUtils, PythTestUtils {
             uint updateFee
         ) = createBatchedUpdateDataFromMessages(messages);
 
-        // Store prices before update
-        PythStructs.Price[] memory originalPrices = new PythStructs.Price[](priceIds.length);
-        for (uint i = 0; i < priceIds.length; i++) {
-            originalPrices[i] = pyth.getPriceUnsafe(priceIds[i]);
-        }
-
         pyth.parsePriceFeedUpdatesWithConfig{
             value: updateFee
-        }(updateData, priceIds, 0, MAX_UINT64, false, true, true);
+        }(updateData, priceIds, 0, MAX_UINT64, false, true, false);
 
-        // validate that stored prices of each priceId are same as before update
-        for (uint i = 0; i < priceIds.length; i++) {
-            PythStructs.Price memory curPrice = pyth.getPriceUnsafe(
-                priceIds[i]
-            );
-
-            assertEq(curPrice.price, originalPrices[i].price);
-            assertEq(curPrice.conf, originalPrices[i].conf);
-            assertEq(curPrice.expo, originalPrices[i].expo);
-            assertEq(curPrice.publishTime, originalPrices[i].publishTime);
+        // validate that stored prices of each priceId are still unpopulated
+        for (uint i = 0; i < numMessages; i++) {
+            vm.expectRevert(PythErrors.PriceFeedNotFound.selector);
+            pyth.getPriceUnsafe(priceIds[i]);
         }
     }