[hermes] Fix memory leak (#881)

ali-behjati · web-flow · commit f394d9e7610f · 2023-06-13T17:11:47.000+02:00
diff --git a/hermes/Cargo.lock b/hermes/Cargo.lock
diff --git a/hermes/Cargo.toml b/hermes/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name                           = "hermes"
-version                        = "0.1.0"
+version                        = "0.1.1"
 edition                        = "2021"
 
 [dependencies]
diff --git a/hermes/src/network/p2p.go b/hermes/src/network/p2p.go
@@ -203,11 +203,11 @@ func RegisterObservationCallback(f C.callback_t, network_id, bootstrap_addrs, li
 					case *GossipMessage_SignedVaaWithQuorum:
 						vaaBytes := msg.GetSignedVaaWithQuorum().GetVaa()
 						cBytes := C.CBytes(vaaBytes)
-						defer C.free(cBytes)
 						C.invoke(f, C.observation_t{
 							vaa:     (*C.char)(cBytes),
 							vaa_len: C.size_t(len(vaaBytes)),
 						})
+						C.free(cBytes)
 					}
 				}
 			}

Original file line number	Diff line number	Diff line change
`@@ -203,11 +203,11 @@ func RegisterObservationCallback(f C.callback_t, network_id, bootstrap_addrs, li`
`203`	`203`	`case *GossipMessage_SignedVaaWithQuorum:`
`204`	`204`	`vaaBytes := msg.GetSignedVaaWithQuorum().GetVaa()`
`205`	`205`	`cBytes := C.CBytes(vaaBytes)`
`206`		`- defer C.free(cBytes)`
`207`	`206`	`C.invoke(f, C.observation_t{`
`208`	`207`	`vaa: (*C.char)(cBytes),`
`209`	`208`	`vaa_len: C.size_t(len(vaaBytes)),`
`210`	`209`	`})`
	`210`	`+ C.free(cBytes)`
`211`	`211`	`}`
`212`	`212`	`}`
`213`	`213`	`}`