Skip to content

Commit f94c03f

Browse files
fix: format code to pass CI
Co-Authored-By: Tejas Badadare <[email protected]>
1 parent 2ee0169 commit f94c03f

File tree

2 files changed

+49
-39
lines changed

2 files changed

+49
-39
lines changed

target_chains/ethereum/contracts/contracts/pulse/Scheduler.sol

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -530,19 +530,18 @@ abstract contract Scheduler is IScheduler, SchedulerState {
530530
SubscriptionStatus storage status = _state.subscriptionStatuses[
531531
subscriptionId
532532
];
533-
533+
534534
if (!params.isActive) {
535535
revert InactiveSubscription();
536536
}
537537

538-
539538
// Check deposit limit for permanent subscriptions
540539
if (params.isPermanent && msg.value > MAX_DEPOSIT_LIMIT) {
541540
revert MaxDepositLimitExceeded();
542541
}
543542

544543
status.balanceInWei += msg.value;
545-
544+
546545
// If subscription is active, ensure minimum balance is maintained
547546
if (params.isActive) {
548547
uint256 minimumBalance = this.getMinimumBalance(

target_chains/ethereum/contracts/forge-test/PulseScheduler.t.sol

Lines changed: 47 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -541,36 +541,36 @@ contract SchedulerTest is Test, SchedulerEvents, PulseSchedulerTestUtils {
541541
"Balance should match initial balance plus added funds"
542542
);
543543
}
544-
545544

546-
547545
function testAddFundsEnforcesMinimumBalance() public {
548546
// First add a subscription with minimum balance
549547
uint256 subscriptionId = addTestSubscription(
550548
scheduler,
551549
address(reader)
552550
);
553-
551+
554552
// Get subscription parameters and initial balance
555-
(SchedulerState.SubscriptionParams memory params, SchedulerState.SubscriptionStatus memory status) = scheduler
556-
.getSubscription(subscriptionId);
557-
553+
(
554+
SchedulerState.SubscriptionParams memory params,
555+
SchedulerState.SubscriptionStatus memory status
556+
) = scheduler.getSubscription(subscriptionId);
557+
558558
// Calculate minimum balance
559559
uint256 minimumBalance = scheduler.getMinimumBalance(
560560
uint8(params.priceIds.length)
561561
);
562-
562+
563563
// Verify initial balance is at minimum
564564
assertEq(
565565
status.balanceInWei,
566566
minimumBalance,
567567
"Initial balance should equal minimum balance"
568568
);
569-
569+
570570
// Add some funds to the subscription
571571
uint256 additionalFunds = 0.1 ether;
572572
scheduler.addFunds{value: additionalFunds}(subscriptionId);
573-
573+
574574
// Verify funds were added
575575
(, SchedulerState.SubscriptionStatus memory statusAfterAdd) = scheduler
576576
.getSubscription(subscriptionId);
@@ -579,26 +579,29 @@ contract SchedulerTest is Test, SchedulerEvents, PulseSchedulerTestUtils {
579579
minimumBalance + additionalFunds,
580580
"Balance should be increased by the added funds"
581581
);
582-
582+
583583
// Now create a new subscription but don't fund it fully
584-
SchedulerState.SubscriptionParams memory newParams = createDefaultSubscriptionParams(
585-
2,
586-
address(reader)
587-
);
588-
584+
SchedulerState.SubscriptionParams
585+
memory newParams = createDefaultSubscriptionParams(
586+
2,
587+
address(reader)
588+
);
589+
589590
// Calculate minimum balance for this new subscription
590591
uint256 newMinimumBalance = scheduler.getMinimumBalance(
591592
uint8(newParams.priceIds.length)
592593
);
593-
594+
594595
// Try to create with insufficient funds
595596
uint256 insufficientFunds = newMinimumBalance - 1 wei;
596597
vm.expectRevert(abi.encodeWithSelector(InsufficientBalance.selector));
597598
scheduler.createSubscription{value: insufficientFunds}(newParams);
598-
599+
599600
// Create with sufficient funds
600-
uint256 newSubscriptionId = scheduler.createSubscription{value: newMinimumBalance}(newParams);
601-
601+
uint256 newSubscriptionId = scheduler.createSubscription{
602+
value: newMinimumBalance
603+
}(newParams);
604+
602605
// Verify subscription was created with minimum balance
603606
(, SchedulerState.SubscriptionStatus memory newStatus) = scheduler
604607
.getSubscription(newSubscriptionId);
@@ -608,38 +611,42 @@ contract SchedulerTest is Test, SchedulerEvents, PulseSchedulerTestUtils {
608611
"New subscription balance should equal minimum balance"
609612
);
610613
}
611-
612-
function testAddFundsEnforcesMinimumBalanceForPermanentSubscription() public {
614+
615+
function testAddFundsEnforcesMinimumBalanceForPermanentSubscription()
616+
public
617+
{
613618
// Create a non-permanent subscription first
614619
uint256 subscriptionId = addTestSubscription(
615620
scheduler,
616621
address(reader)
617622
);
618-
623+
619624
// Get subscription parameters and initial balance
620-
(SchedulerState.SubscriptionParams memory params, SchedulerState.SubscriptionStatus memory status) = scheduler
621-
.getSubscription(subscriptionId);
622-
625+
(
626+
SchedulerState.SubscriptionParams memory params,
627+
SchedulerState.SubscriptionStatus memory status
628+
) = scheduler.getSubscription(subscriptionId);
629+
623630
// Calculate minimum balance
624631
uint256 minimumBalance = scheduler.getMinimumBalance(
625632
uint8(params.priceIds.length)
626633
);
627-
634+
628635
// Verify initial balance is at minimum
629636
assertEq(
630637
status.balanceInWei,
631638
minimumBalance,
632639
"Initial balance should equal minimum balance"
633640
);
634-
641+
635642
// Make it permanent
636643
params.isPermanent = true;
637644
scheduler.updateSubscription(subscriptionId, params);
638-
645+
639646
// Try to add funds - this should succeed since we're adding to a permanent subscription
640647
uint256 additionalFunds = 0.1 ether;
641648
scheduler.addFunds{value: additionalFunds}(subscriptionId);
642-
649+
643650
// Verify funds were added
644651
(, SchedulerState.SubscriptionStatus memory statusAfter) = scheduler
645652
.getSubscription(subscriptionId);
@@ -648,21 +655,25 @@ contract SchedulerTest is Test, SchedulerEvents, PulseSchedulerTestUtils {
648655
minimumBalance + additionalFunds,
649656
"Balance should be increased by the added funds"
650657
);
651-
658+
652659
// Now test the deposit limit for permanent subscriptions
653660
uint256 maxDepositLimit = 100 ether; // MAX_DEPOSIT_LIMIT from SchedulerState
654-
661+
655662
// Try to add funds exceeding the deposit limit
656-
vm.expectRevert(abi.encodeWithSelector(MaxDepositLimitExceeded.selector));
663+
vm.expectRevert(
664+
abi.encodeWithSelector(MaxDepositLimitExceeded.selector)
665+
);
657666
scheduler.addFunds{value: maxDepositLimit + 1}(subscriptionId);
658-
667+
659668
// Add funds within the deposit limit
660669
uint256 validDeposit = 1 ether;
661670
scheduler.addFunds{value: validDeposit}(subscriptionId);
662-
671+
663672
// Verify funds were added
664-
(, SchedulerState.SubscriptionStatus memory statusAfterValidDeposit) = scheduler
665-
.getSubscription(subscriptionId);
673+
(
674+
,
675+
SchedulerState.SubscriptionStatus memory statusAfterValidDeposit
676+
) = scheduler.getSubscription(subscriptionId);
666677
assertEq(
667678
statusAfterValidDeposit.balanceInWei,
668679
minimumBalance + additionalFunds + validDeposit,

0 commit comments

Comments
 (0)