refactor(twap): change window_seconds type from i64 to u64 in get_twaps_with_update_data function

Author: tejasbadadare

apps/hermes/server/src/api/rest.rs

@@ -201,7 +201,7 @@ mod tests {
         async fn get_twaps_with_update_data(
             &self,
             _price_ids: &[PriceIdentifier],
-            _window_seconds: i64,
+            _window_seconds: u64,
             _end_time: RequestTime,
         ) -> Result<TwapsWithUpdateData> {
             unimplemented!("Not needed for this test")

apps/hermes/server/src/api/rest/v2/latest_twaps.rs

@@ -109,7 +109,7 @@ where
     let twaps_with_update_data = Aggregates::get_twaps_with_update_data(
         &*state.state,
         &price_ids,
-        path_params.window_seconds as i64,
+        path_params.window_seconds,
         RequestTime::LatestTimeEarliestSlot,
     )
     .await

apps/hermes/server/src/state/aggregate.rs

@@ -244,7 +244,7 @@ where
     async fn get_twaps_with_update_data(
         &self,
         price_ids: &[PriceIdentifier],
-        window_seconds: i64,
+        window_seconds: u64,
         end_time: RequestTime,
     ) -> Result<TwapsWithUpdateData>;
 }
@@ -412,7 +412,7 @@ where
     async fn get_twaps_with_update_data(
         &self,
         price_ids: &[PriceIdentifier],
-        window_seconds: i64,
+        window_seconds: u64,
         end_time: RequestTime,
     ) -> Result<TwapsWithUpdateData> {
         match get_verified_twaps_with_update_data(self, price_ids, window_seconds, end_time.clone())
@@ -634,7 +634,7 @@ where
 async fn get_verified_twaps_with_update_data<S>(
     state: &S,
     price_ids: &[PriceIdentifier],
-    window_seconds: i64,
+    window_seconds: u64,
     end_time: RequestTime,
 ) -> Result<TwapsWithUpdateData>
 where
@@ -663,7 +663,7 @@ where
         ));
     } else {
         // Use the publish time from the first end message
-        end_messages[0].message.publish_time() - window_seconds
+        end_messages[0].message.publish_time() - window_seconds as i64
     };
     let start_time = RequestTime::FirstAfter(start_timestamp);
 

apps/hermes/server/src/state/cache.rs

@@ -292,7 +292,7 @@ async fn retrieve_message_state(
                     let mut latest_entry_with_earliest_slot = last_entry;
 
                     // Walk backwards through the sorted entries rather than use `range` since we will only
-                    // have 1-2 entries that have the same publish_time.
+                    // have a couple entries that have the same publish_time.
                     // We have acquired the RwLock via read() above, so we should be safe to reenter the cache here.
                     for (k, v) in key_cache.iter().rev() {
                         if k.publish_time < latest_publish_time {