feat(staking): make wallet optional in staking sdk #1932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
guibescos
reviewed
Sep 18, 2024
| } | ||
|
|
||
| public async getClaimableRewards(stakeAccountPositions: PublicKey) { | ||
| this.assertWallet(); |
There was a problem hiding this comment.
does this one require a wallet?
There was a problem hiding this comment.
it's using this.wallet.publicKey but since it's only the simulation i think we can replace this with any pubkey.
guibescos
reviewed
Sep 18, 2024
| this.provider = new AnchorProvider(this.connection, this.wallet, { | ||
|
|
||
| // {} as AnchorWallet is a workaround for AnchorProvider requiring a wallet | ||
| this.provider = new AnchorProvider(this.connection, this.wallet ?? {} as AnchorWallet, { |
There was a problem hiding this comment.
no, but the check is for this.wallet not the {} in the provider.
guibescos
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.