feat(staking): make sdk ready for release #1933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
guibescos
reviewed
Sep 18, 2024
|
|
||
| const packageJson = JSON.parse(fs.readFileSync(distPackageJsonPath, "utf8")); | ||
|
|
||
| packageJson.exports = { |
There was a problem hiding this comment.
there must be a better way to deal with this 😃
There was a problem hiding this comment.
Let's see what @cprussin says
There was a problem hiding this comment.
I actually have a package for doing this: https://www.npmjs.com/package/@cprussin/transform-package-json
You essentially have to do some transformation like this to the package.json to dual export packages or to use nextjs's transpileModules on a package that gets published, so I think it's fine however you want to do this, and what you have here is perfectly ok
cprussin
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.