feat(staking): add stake accounts and supply routes #1957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
keyvankhademi
changed the title
cprussin
approved these changes
Sep 24, 2024
| } else { | ||
| const pythMint = await stakingClient.getPythTokenMint(); | ||
| return getResponse(Number(pythMint.supply)); | ||
| } |
There was a problem hiding this comment.
Seems a bit odd to me to have a single endpoint that has a query param that enables it to do two totally different and unrelated things. Why not just split these into separate endpoints?
There was a problem hiding this comment.
i 100% agree, but let's keep it the same for now since other users are already integrated using this with the old ui.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.