Skip to content

Conversation

@cprussin
Copy link
Collaborator

@cprussin cprussin commented Oct 7, 2024

This PR adds better feedback to the staking app. Included are:

  • Better error messages
  • Toasts on success / failure (failure toasts only show where there isn't a modal to display the error message)
  • Buttons go into a spinner state when isLoading is true

@vercel
Copy link

vercel bot commented Oct 7, 2024

@cprussin is attempting to deploy a commit to the Pyth Network Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Oct 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 1:22am
staking ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 1:22am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
proposals ⬜️ Ignored (Inspect) Visit Preview Oct 7, 2024 1:22am

This PR adds better feedback to the staking app.  Included are:

- Better error messages
- Toasts on success / failure (failure toasts only show where there isn't a
  modal to display the error message)
- Buttons go into a spinner state when isLoading is true
@cprussin cprussin merged commit 8ebdcf2 into pyth-network:main Oct 7, 2024
6 checks passed
@cprussin cprussin deleted the improve-errors branch October 7, 2024 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant