fix(governance/xc_admin): init publishers for price store only when n… #2149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
Riateche
approved these changes
Nov 27, 2024
| const initPublisher = async (publisherKey: PublicKey) => { | ||
| const initPublisherInPriceStore = async (publisherKey: PublicKey) => { | ||
| // Price store is only available in Pythnet and Pythtest-crosschain | ||
| if (cluster !== 'pythnet' && cluster !== 'pythtest-crosschain') { |
Contributor
There was a problem hiding this comment.
Maybe a better option would be to check if price store program is deployed on the current chain?
Collaborator
Author
There was a problem hiding this comment.
Hmmm that also works. I wanted to avoid doing it for pythtest-conformance but it doesn't matter probably.
ali-behjati
force-pushed
the
xc-admin-frontend/fix-price-store
branch
from
947c2cf to
c8765e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…eeded