Skip to content

fix(governance/xc_admin): init publishers for price store only when n… #2149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 27, 2024
Merged

fix(governance/xc_admin): init publishers for price store only when n… #2149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f14ef56
fix(governance/xc_admin): init publishers for price store only when n…
ali-behjati Nov 27, 2024
c8765e3
fix: address feedback
ali-behjati Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions governance/xc_admin/packages/xc_admin_common/src/price_store.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,3 +331,11 @@ export async function isPriceStorePublisherInitialized(
const response = await connection.getAccountInfo(publisherConfigKey);
return response !== null;
}

export async function isPriceStoreInitialized(
connection: Connection
): Promise<boolean> {
const configKey = findPriceStoreConfigAddress()[0];
const response = await connection.getAccountInfo(configKey);
return response !== null;
}
18 changes: 12 additions & 6 deletions governance/xc_admin/packages/xc_admin_frontend/components/tabs/General.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import {
PRICE_FEED_OPS_KEY,
getMessageBufferAddressForPrice,
getMaximumNumberOfPublishers,
isPriceStoreInitialized,
isPriceStorePublisherInitialized,
createDetermisticPriceStoreInitializePublisherInstruction,
} from '@pythnetwork/xc-admin-common'
Expand Down Expand Up @@ -290,7 +291,7 @@ const General = ({ proposerServerUrl }: { proposerServerUrl: string }) => {
const handleSendProposalButtonClick = async () => {
if (pythProgramClient && dataChanges && !isMultisigLoading && squads) {
const instructions: TransactionInstruction[] = []
const publisherInitializationsVerified: PublicKey[] = []
const publisherInPriceStoreInitializationsVerified: PublicKey[] = []

for (const symbol of Object.keys(dataChanges)) {
const multisigAuthority = squads.getAuthorityPDA(
Expand All @@ -301,9 +302,14 @@ const General = ({ proposerServerUrl }: { proposerServerUrl: string }) => {
? mapKey(multisigAuthority)
: multisigAuthority

const initPublisher = async (publisherKey: PublicKey) => {
const initPublisherInPriceStore = async (publisherKey: PublicKey) => {
// Ignore this step if Price Store is not initialized (or not deployed)
if (!connection || !(await isPriceStoreInitialized(connection))) {
return
}

if (
publisherInitializationsVerified.every(
publisherInPriceStoreInitializationsVerified.every(
(el) => !el.equals(publisherKey)
)
) {
Expand All @@ -321,7 +327,7 @@ const General = ({ proposerServerUrl }: { proposerServerUrl: string }) => {
)
)
}
publisherInitializationsVerified.push(publisherKey)
publisherInPriceStoreInitializationsVerified.push(publisherKey)
}
}
const { prev, new: newChanges } = dataChanges[symbol]
Expand Down Expand Up @@ -406,7 +412,7 @@ const General = ({ proposerServerUrl }: { proposerServerUrl: string }) => {
})
.instruction()
)
await initPublisher(publisherPubKey)
await initPublisherInPriceStore(publisherPubKey)
}

// create set min publisher instruction if there are any publishers
Expand Down Expand Up @@ -576,7 +582,7 @@ const General = ({ proposerServerUrl }: { proposerServerUrl: string }) => {
})
.instruction()
)
await initPublisher(publisherPubKey)
await initPublisherInPriceStore(publisherPubKey)
}
}
}
Expand Down
Loading