Skip to content

fix(governance/xc_admin): init publishers for price store only when n… #2149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 27, 2024
Merged

fix(governance/xc_admin): init publishers for price store only when n… #2149

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f14ef56
fix(governance/xc_admin): init publishers for price store only when n…
ali-behjati Nov 27, 2024
c8765e3
fix: address feedback
ali-behjati Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions governance/xc_admin/packages/xc_admin_frontend/components/tabs/General.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ const General = ({ proposerServerUrl }: { proposerServerUrl: string }) => {
const handleSendProposalButtonClick = async () => {
if (pythProgramClient && dataChanges && !isMultisigLoading && squads) {
const instructions: TransactionInstruction[] = []
const publisherInitializationsVerified: PublicKey[] = []
const publisherInPriceStoreInitializationsVerified: PublicKey[] = []

for (const symbol of Object.keys(dataChanges)) {
const multisigAuthority = squads.getAuthorityPDA(
Expand All @@ -301,9 +301,14 @@ const General = ({ proposerServerUrl }: { proposerServerUrl: string }) => {
? mapKey(multisigAuthority)
: multisigAuthority

const initPublisher = async (publisherKey: PublicKey) => {
const initPublisherInPriceStore = async (publisherKey: PublicKey) => {
// Price store is only available in Pythnet and Pythtest-crosschain
if (cluster !== 'pythnet' && cluster !== 'pythtest-crosschain') {
Copy link
Contributor

@Riateche Riateche Nov 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a better option would be to check if price store program is deployed on the current chain?

Copy link
Collaborator Author

@ali-behjati ali-behjati Nov 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm that also works. I wanted to avoid doing it for pythtest-conformance but it doesn't matter probably.

return
}

if (
publisherInitializationsVerified.every(
publisherInPriceStoreInitializationsVerified.every(
(el) => !el.equals(publisherKey)
)
) {
Expand All @@ -321,7 +326,7 @@ const General = ({ proposerServerUrl }: { proposerServerUrl: string }) => {
)
)
}
publisherInitializationsVerified.push(publisherKey)
publisherInPriceStoreInitializationsVerified.push(publisherKey)
}
}
const { prev, new: newChanges } = dataChanges[symbol]
Expand Down Expand Up @@ -406,7 +411,7 @@ const General = ({ proposerServerUrl }: { proposerServerUrl: string }) => {
})
.instruction()
)
await initPublisher(publisherPubKey)
await initPublisherInPriceStore(publisherPubKey)
}

// create set min publisher instruction if there are any publishers
Expand Down Expand Up @@ -576,7 +581,7 @@ const General = ({ proposerServerUrl }: { proposerServerUrl: string }) => {
})
.instruction()
)
await initPublisher(publisherPubKey)
await initPublisherInPriceStore(publisherPubKey)
}
}
}
Expand Down
Loading