add comments and ignore bounced messages #2151
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
ali-behjati
reviewed
Nov 28, 2024
|
|
||
| ### Message Bouncing Behavior | ||
|
|
||
| - If the target protocol bounces the message (e.g., due to invalid custom payload or other errors), the forwarded TON will remain in the Pyth contract and will not be automatically refunded to the original sender. |
Collaborator
There was a problem hiding this comment.
can't we bounce back?
Contributor
Author
There was a problem hiding this comment.
to handle bounced messages and return funds to the original sender, we need to:
- store the sender's address when receiving the initial request
- add a bounce handling function that checks for bounced messages and refunds the original sender
its not as straightforward but if you think its worth it then we can consider implementing this
Collaborator
There was a problem hiding this comment.
oof it seems pretty complicated. let's skip it.
ali-behjati
approved these changes
Nov 28, 2024
Collaborator
ali-behjati
left a comment
ali-behjati
left a comment
There was a problem hiding this comment.
LGTM. I don't know how much of a lift it is to bounce backwards to refund but it's a nice feature to add.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.