Skip to content

feat: add request duration tracking for Fortuna callbacks #2197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 13, 2024
Merged

feat: add request duration tracking for Fortuna callbacks #2197

merged 2 commits into from
Dec 13, 2024

Conversation

@devin-ai-integration
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Dec 13, 2024 •
edited
Loading

This PR implements request duration tracking for Fortuna callbacks with the following changes:

  1. Added request_duration_ms histogram metric to track callback processing times
  2. Updated histogram buckets to use the following values (in milliseconds):
    • 1000, 2500, 5000, 7500, 10000, 20000, 30000, 40000, 50000, 60000
  3. Bumped Fortuna version from 6.6.0 to 6.7.0

Implementation details:

  • Added timing measurement in process_event_with_backoff using std::time::Instant
  • Configured histogram with specified millisecond-based buckets
  • Maintained existing labeling with chain_id and provider_address

Link to Devin run: https://app.devin.ai/sessions/7028966539c9435daccae7fb60f192bd

@vercel
Copy link

vercel bot commented Dec 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 9:39pm
proposals ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 9:39pm
staking ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 9:39pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
component-library ⬜️ Ignored (Inspect) Visit Preview Dec 13, 2024 9:39pm
insights ⬜️ Ignored (Inspect) Visit Preview Dec 13, 2024 9:39pm

@devin-ai-integration
Copy link
Contributor Author

devin-ai-integration bot commented Dec 13, 2024

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Add "(aside)" to your comment to have me ignore it.

@devin-ai-integration devin-ai-integration bot force-pushed the devin/1734124523-add-request-duration-metric branch from d2a4823 to 3a32fd7 Compare December 13, 2024 21:30
@jayantk jayantk merged commit 3a688cc into main Dec 13, 2024
8 checks passed
@jayantk jayantk deleted the devin/1734124523-add-request-duration-metric branch December 13, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jayantk jayantk jayantk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jayantk